Adding ** to call. #48
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -47,7 +47,7 @@ def validate_blacklist(record, attribute, value) | |||
| end | |||
|
|
|||
| def mark_invalid(record, attribute, types) | |||
| record.errors.add attribute, :invalid, options.merge(types: types.join(", ")) | |||
| record.errors.add attribute, :invalid, **options.merge(types: types.join(", ")) | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [87/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -4,7 +4,7 @@ module Paperclip | |||
| module Validators | |||
| class AttachmentPresenceValidator < ActiveModel::EachValidator | |||
| def validate_each(record, attribute, _value) | |||
| record.errors.add(attribute, :blank, options) if record.send("#{attribute}_file_name").blank? | |||
| record.errors.add(attribute, :blank, **options) if record.send("#{attribute}_file_name").blank? | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [103/80]
| @@ -39,7 +39,7 @@ def validate_each(record, attr_name, value) | |||
| unless value.send(CHECKS[option], option_value) | |||
| error_message_key = options[:in] ? :in_between : option | |||
| error_attrs.each do |error_attr_name| | |||
| record.errors.add(error_attr_name, error_message_key, filtered_options(value).merge( | |||
| record.errors.add(error_attr_name, error_message_key, **filtered_options(value).merge( | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [102/80]
|
The last build failed but is not failing locally for me. Could this be a random failure? I can't restart the build if so. |
|
@adrianmann Thanks for your PR. Can you plz remove the NEWS commit? The file isn't being maintained. This will trigger another build as well, and we will know if it was just a random fragile test failure. Thanks! |
|
I have removed the change to the NEWS file in the latest commit and tests passed this time, please review again. |
|
Bump! :) |
|
Thanks for merging this in, it seems the last build on master has failed. Can the build be restarted, I'd imagine it is an intermittent failure? Edit: Also, when do you think the next release will be? |
|
@ssinghi Is it possible to have a new release with this code please? |
|
Is this fix included in 6.4.1? I'm still getting the Rails 7.0.3 |
|
@rstueven It is in 7.0.0. #46 (comment) |
|
@adrianmann Thanks! Apparently my project uses the defunct paperclip-av-transcoder gem, and it relies on kt-paperclip ~> 6.4, so I'll have to figure out a workaround. |
Please review this code to address the following issue:
#46
I ran my test suite against these changes and I no longer see the warnings. I also ran the kt-paperclip tests an they are passing.