Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State modules to be allowed to have their own generic register handlers #18

Closed
kosarev opened this issue Jul 4, 2021 · 1 comment
Closed

State modules to be allowed to have their own generic register handlers #18

kosarev opened this issue Jul 4, 2021 · 1 comment
Assignees
@kosarev
Labels
bug

Comments

@kosarev
Copy link
Owner

kosarev commented Jul 4, 2021 •
edited
Loading

Working on #17 revealed the problem with the state modules not having their own on_get_reg(), on_get_regp(), etc. handlers. That's certainly something up to them to implement as it directly affects available design choices.

A subtask of #17.
@kosarev kosarev added the bug label Jul 4, 2021
@kosarev kosarev self-assigned this Jul 4, 2021
@kosarev kosarev changed the title State modules to have their own generic register handlers State modules to be allowed to have their own generic register handlers Jul 4, 2021
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move the generic implementations of the on_get_reg() handlers t…
662cef6 
…o the root module.
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move the generic implementations of the on_set_reg() handlers t…
28aa3f3 
…o the root module.
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Register-pair handlers to take the index register accessed.
e7aead6
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move the generic implementations of index register handlers to …
b1cc451 
…the root module.
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move the generic implementations of the on_get_regp() handlers …
c8c481d 
…to the root module.
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move the generic implementations of the on_set_regp() handlers …
4e9cc50 
…to the root module.
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move the generic implementations of the on_get_regp2() handlers…
450046a 
… to the root module.
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move the generic implementations of the on_set_regp2() handlers…
1f32317 
… to the root module.
kosarev added a commit that referenced this issue Jul 4, 2021
@kosarev
[#18] Move Z80-specific register handlers to the root.
f4ee1f5
@kosarev
Copy link
Owner Author

kosarev commented Jul 4, 2021

Done. Now state modules can handle any accesses to registers, including generic ones, as they like.

@kosarev kosarev closed this as completed Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kosarev kosarev

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kosarev