Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Custom activity support to PresenceBuilder #984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meqativ
Copy link

@meqativ meqativ commented Oct 1, 2024

No description provided.

Copy link

@fres621 fres621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DRSchlaubi
Copy link
Member

Please run ./gradlew apiDump

Comment on lines +42 to +44
public fun custom(name: String) {
game = DiscordBotActivity(name, ActivityType.Custom)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public fun custom(name: String) {
game = DiscordBotActivity(name, ActivityType.Custom)
}
public fun custom(state: String) {
game = null
this.state = state
}

see #857 (review) for why this should be implemented this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants