Switch to codegen.kt #965
Open
Switch to codegen.kt #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think codegen kt doesn't run on jdk 8 |
lukellmann
reviewed
Aug 11, 2024
buildSrc/src/main/kotlin/Projects.kt
Outdated
| @@ -29,5 +29,5 @@ val Project.isRelease get() = tag != null | |||
|
|
|||
| object Repo { | |||
| const val releasesUrl = "https://oss.sonatype.org/service/local/staging/deploy/maven2/" | |||
| const val snapshotsUrl = "https://oss.sonatype.org/content/repositories/snapshots/" | |||
There was a problem hiding this comment.
shouldn't we do it like this in #961?
| @@ -1,16 +1,24 @@ | |||
| @file:OptIn(ExperimentalContracts::class, DelicateKotlinPoetApi::class) | |||
There was a problem hiding this comment.
i don't like the opt-ins here, why not keep the old approach of using strings?
There was a problem hiding this comment.
Because this one is actually type-safe and I like it
the build failure looks more like a dependency resolution issue |
|
Yeah because codegen.kt defines a jdk dependency in the Gradle meta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.