Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish KSP processors #845

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Publish KSP processors #845

wants to merge 3 commits into from

Conversation

DRSchlaubi
Copy link
Member

I want to use this in my OAuth lib, so would be useful to have it

@lukellmann
Copy link
Member

i think we shouldn't advertise it though, there won't be any stability and compatibility gurantees

@DRSchlaubi
Copy link
Member Author

Yeah sure, that's why I only published it and didn't add a readme or anything

@lukellmann
Copy link
Member

also wouldn't a pure snapshot branch with this change be enough?

@DRSchlaubi
Copy link
Member Author

Ig, but if we update the processor, we also need to update this

@lukellmann
Copy link
Member

true, it's ok for me then.

however are you sure that ksp-processors is really published (check with the snapshot of the branch), kord-module.kts also registers a publication, while this build.gradle.kts does not.
a comment about why this is published would also be good.

and remember, we might change from using annotations/ksp for generating to a custom dsl and gradle task / simple application with main() instead. reason being that there is almost no benifit but rather limitations from using annotations for the data about what should be generated (we discussed this before).

@lukellmann
Copy link
Member

i thought about this again, can't we simply add the types you need to kord?

@DRSchlaubi
Copy link
Member Author

No, it's also used in lavalink.kt

@lukellmann
Copy link
Member

lukellmann commented Dec 22, 2023

so for non-discord-related generation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants