Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Eclipse OpenJ9 (to gain performance) #481

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e55202f
Switch to Eclipse OpenJ9 JDK v15
koppor Jan 1, 2021
f1a316f
Merge remote-tracking branch 'origin/master' into switch-to-openj9
koppor Jan 21, 2021
2267aa5
Always use Java 14
koppor Jan 21, 2021
274667a
14 also at tests.yml
koppor Jan 21, 2021
e34d3e4
Merge branch 'main' into switch-to-openj9
koppor May 7, 2021
a85f9ca
Result of ./gradlew suggestMergedModuleInfo
koppor May 7, 2021
a88b1aa
Merge branch 'update-merged-module' into switch-to-openj9
koppor May 7, 2021
8ce6d55
Remove jackson requirements
koppor May 7, 2021
f7bf223
Merge branch 'update-merged-module' into switch-to-openj9
koppor May 7, 2021
80fda8f
Remove some more
koppor May 7, 2021
ef712a0
Merge branch 'update-merged-module' into switch-to-openj9
koppor May 7, 2021
f1d472a
Merge branch 'main' into switch-to-openj9
koppor Jun 23, 2022
8ae077b
Remove jdk.jfr
koppor Jun 23, 2022
acd54c2
Merge remote-tracking branch 'origin/main' into switch-to-openj9
koppor Sep 25, 2022
535d838
Fine-tune OpenJ9
koppor Sep 25, 2022
e2473e1
Remove -Xgcpolicy:balanced
koppor Sep 26, 2022
7f2a206
Update build.gradle
koppor Sep 26, 2022
5f9f738
Merge remote-tracking branch 'origin/main' into switch-to-openj9
koppor Oct 9, 2022
83b7099
Merge branch 'switch-to-openj9' of github.com:koppor/jabref into swit…
koppor Oct 9, 2022
467b8ad
Merge remote-tracking branch 'origin/main' into switch-to-openj9
koppor Oct 12, 2022
d7ce24e
Merge remote-tracking branch 'upstream/main' into switch-to-openj9
koppor Jan 9, 2024
df7d28f
Fix distribution name
koppor Jan 9, 2024
9874602
Merge branch 'main' into switch-to-openj9
koppor May 17, 2024
10dde03
Adapt config
koppor May 17, 2024
69e096c
Fix jvmArgs
koppor May 17, 2024
957d057
Switch back to JDK21
koppor May 17, 2024
9f0419f
Also build image in case of non-secrets precense
koppor May 19, 2024
707172b
Merge remote-tracking branch 'origin/main' into switch-to-openj9
koppor May 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deployment-jdk-ea.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest, buildjet-4vcpu-ubuntu-2204-arm]
jdk: [22]
jdk: [21]
javafx: [23]
include:
- os: ubuntu-latest
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,21 +188,21 @@ jobs:
--java-options --add-opens=javafx.controls/javafx.scene.control=org.jabref \
--java-options --add-opens=javafx.controls/com.sun.javafx.scene.control=org.jabref
- name: Build runtime image and installer (linux, Windows)
if: (matrix.os != 'macos-latest') && (steps.checksecrets.outputs.secretspresent == 'YES')
if: (matrix.os != 'macos-latest')
shell: bash
run: ./gradlew -i -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }}" -PprojVersionInfo="${{ steps.gitversion.outputs.InformationalVersion }}" jpackage jlinkZip
- name: Package application image (linux, Windows)
if: (matrix.os != 'macos-latest') && (steps.checksecrets.outputs.secretspresent == 'YES')
if: (matrix.os != 'macos-latest')
shell: bash
run: ${{ matrix.archivePortable }}
- name: Rename files
if: (matrix.os != 'macos-latest') && (steps.checksecrets.outputs.secretspresent == 'YES')
if: (matrix.os != 'macos-latest')
shell: pwsh
run: |
get-childitem -Path build/distribution/* | rename-item -NewName {$_.name -replace "${{ steps.gitversion.outputs.AssemblySemVer }}","${{ steps.gitversion.outputs.Major }}.${{ steps.gitversion.outputs.Minor }}"}
get-childitem -Path build/distribution/* | rename-item -NewName {$_.name -replace "portable","${{ steps.gitversion.outputs.Major }}.${{ steps.gitversion.outputs.Minor }}-portable"}
- name: Repack deb file for Debian
if: (matrix.os == 'ubuntu-latest') && (steps.checksecrets.outputs.secretspresent == 'YES')
if: (matrix.os == 'ubuntu-latest')
shell: bash
run: |
cd build/distribution
Expand Down
9 changes: 8 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ java {
// - .github/workflows/deployment-jdk-ea.yml#L53
languageVersion = JavaLanguageVersion.of(21)
// See https://docs.gradle.org/current/javadoc/org/gradle/jvm/toolchain/JvmVendorSpec.html for a full list
// vendor = JvmVendorSpec.AMAZON
vendor = JvmVendorSpec.IBM
}
}

Expand Down Expand Up @@ -656,6 +656,13 @@ jlink {
addOptions('--strip-debug', '--compress', 'zip-6', '--no-header-files', '--no-man-pages')
launcher {
name = 'JabRef'

// -Xgcpolicy:balanced
// Use "balanced" policy, which should provide better application performance
// See for details https://www.eclipse.org/openj9/docs/gc/#balanced-policy
// -Xms220M
// Provide more than 8 MB initial heap size (defaults are listed at https://www.eclipse.org/openj9/docs/openj9_defaults/)
jvmArgs = ['-Xgcpolicy:balanced', '-Xms220M']
}

addOptions("--bind-services")
Expand Down
Loading