Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if local clock and host clock are out of sync #1448

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kke
Copy link
Contributor

@kke kke commented Aug 7, 2019

Shows a warning if localhost and host clocks are more than 60 seconds apart.

image

@kke kke added the enhancement New feature or request label Aug 7, 2019
@jakolehm jakolehm added this to the 2.5.0 milestone Aug 26, 2019
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing this in the output:

    [default-master-0] Retrying after 2 seconds (#33) ...
    [default-master-0] SSL_connect returned=1 errno=0 state=error: certificate verify failed (certificate is not yet valid) (OpenSSL::SSL::SSLError) Unable to verify certificate. This may be an issue with the remote host or with Excon. Excon has certificates bundled, but these can be customized:
    [default-master-0] 
    [default-master-0]             `Excon.defaults[:ssl_ca_path] = path_to_certs`
    [default-master-0]             `ENV['SSL_CERT_DIR'] = path_to_certs`
    [default-master-0]             `Excon.defaults[:ssl_ca_file] = path_to_file`
    [default-master-0]             `ENV['SSL_CERT_FILE'] = path_to_file`
    [default-master-0]             `Excon.defaults[:ssl_verify_callback] = callback`
    [default-master-0]                 (see OpenSSL::SSL::SSLContext#verify_callback)
    [default-master-0] or:
    [default-master-0]             `Excon.defaults[:ssl_verify_peer] = false` (less secure).

Can we format it better (without excon stuff)?

@kke
Copy link
Contributor Author

kke commented Sep 2, 2019

Now it should only display [default-master-0] SSL_connect returned=1 errno=0 state=error: certificate verify failed (certificate is not yet valid)

@@ -17,7 +17,11 @@ def self.format_exception(exc, severity = "ERROR")
backtrace = "\n #{exc.backtrace.join("\n ")}"
end

"Error: #{exc.message.strip}#{backtrace}"
if exc.is_a?(Excon::Errors::CertificateError)
"Error: #{exc.message.lines.first[/(.+?\))/, 1]}#{backtrace}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really safe? Does excon always have (something) in place that we can use for search?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants