Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewalld as DaemonSet #1429

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Firewalld as DaemonSet #1429

wants to merge 7 commits into from

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Jun 24, 2019

Moves firewalld from host to Kubernetes DaemonSet.

Also bumps DNS node cache to v1.15.2 (handles iptables changes better).

@jakolehm jakolehm added the enhancement New feature or request label Jun 24, 2019
@jakolehm jakolehm requested a review from jnummelin June 24, 2019 06:53
@@ -61,12 +47,19 @@ spec:
name: weave-passwd
key: weave-passwd
image: '<%= image_repository %>/weave-kube:<%= version %>'
livenessProbe:
readinessProbe:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream has already switched to readinessProbe.

httpGet:
host: 127.0.0.1
path: /status
port: 6784
initialDelaySeconds: 30
livenessProbe:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that required iptables rules are in place.

Copy link
Contributor

@jnummelin jnummelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we can merge this now using the latest tag of the FW image to allow faster iteration. Then when getting closer to release we could switch to tagged version.

@jakolehm jakolehm added this to the 2.5.0 milestone Jun 24, 2019
@jakolehm
Copy link
Contributor Author

jakolehm commented Sep 2, 2019

@jnummelin this breaks systems with POSTROUTING SNAT rule for systemd-resolved stub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants