Vultr fix

[jokestax]

Description

Implemented a timout error as cluster deployment takes some time to get deployed,otherwise it wont wait for the cluster and returns an connection refused error

How to test

kubefirst beta vultr create --alerts-email <ALERT_MAIL> --github-org <ORG_NAME> --domain-name <DOMAIN_NAME> --gitops-template-branch patch-1 --cluster-name <CLUSTER_NAME> --gitops-template-url https://github.com/Seven45/gitops-template

[patrickdappollonio]

To get some more context here, why is it that the watch process fails? Is it because the pod hasn't been created there yet so you get 404s?

[patrickdappollonio]

Either way is good with me so approving this but I think we don't need the extra difficulty if we're going to end up passing a single label anyways.

Thank you, this looks great!

[fharper]

@patrickdappollonio you also tested this PR since you approved it, not just checked the code? Just want to be sure as I won't test it since you approved.

[patrickdappollonio]

We made a unit test, but I don't think @jokestax shared it. Might need the human test instead.

[jokestax]

It needs a manual test :)

[fharper]

All PRs need to be tested in a way or another (often E2E) before we approved them, not just code reviews. I assumed it was done when approved, but no worries, I'll try to find time today to test it also :)

[fharper]

When running it, I got this error.

Not much more information in the logs.

Any idea if it's a code 18 or something in the code?

[jokestax]

Ohh when you are trying to run api locally there is new change done ,we have export K1_CONSOLE_REMOTE_URL="http://localhost:3000"

[fharper]

Oh OK, we should add this to the . env file if not already done. I will give it another try, thanks.

[patrickdappollonio]

@mrsimonemms this might be good to have in the .devcontainer so instead of having people run the long command I see in @fharper's screenshot, it could simply be run through the container.

[patrickdappollonio]

Oh wait, maybe that's kubefirst, not kubefirst-api, my bad.

[fharper]

I tried this PR, and I wasn't able to get a successful run: it's stuck at wrapping up", but I don't think it's related to this fix. I didn't get the timeout issue on Argo CD or Vault, so I think we can merge.