Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(1165) : collector whale entity + resolver #87

Merged
merged 10 commits into from
Jun 3, 2022
Merged

Feat(1165) : collector whale entity + resolver #87

merged 10 commits into from
Jun 3, 2022

Conversation

MSghais
Copy link
Contributor

@MSghais MSghais commented May 22, 2022

  1. Create an Entity Collector
  2. Add schema
  3. Resolver collectorTable

@MSghais MSghais changed the title init collector whale Feat(1165) : collector whale entity + resolver May 22, 2022
vikiival
vikiival requested changes May 22, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you need both cache and resolver?

@vikiival
Copy link
Member

nooooo :D

@MSghais
Copy link
Contributor Author

MSghais commented May 22, 2022

nooooo :D

Ah excuse me, about what ?

@MSghais MSghais requested a review from vikiival May 22, 2022 16:02
@vikiival
Copy link
Member

The cache implemetation was better/ preffered over resolver imo

@MSghais MSghais mentioned this pull request May 23, 2022
Closed
17 tasks
vikiival
vikiival reviewed May 24, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@vikiival
Copy link
Member

6ha4za

@vikiival
Copy link
Member

It's written in this commit 1e13053

vikiival
vikiival reviewed May 27, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to test.

@MSghais MSghais requested a review from vikiival May 29, 2022 23:38
vikiival
vikiival approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks oki may @petersopko can test ? 🥺

This was referenced May 31, 2022
Closed
Closed
Merged
Open
@vikiival
Copy link
Member

vikiival commented Jun 2, 2022

Sir we tried your impl but seems like the query does not return any results

@MSghais
Copy link
Contributor Author

MSghais commented Jun 2, 2022

Sir we tried your impl but seems like the query does not return any results

Hi, actually I used the collectorTable for the pagination in the frontend. Because the cache update is pretty long, and we need a refresh and last data in the UI with pagination, that's why I used the resolver.

@vikiival
Copy link
Member

vikiival commented Jun 2, 2022

why I used the resolver

Yeah but resolver is pretty heavy for the indexer :) and we have a couple of outages (check #88 )

@vikiival vikiival merged commit bbfb66a into kodadot:main Jun 3, 2022
@vikiival
Copy link
Member

vikiival commented Jun 3, 2022

YOLO

@vikiival
Copy link
Member

Looks like YOLO broke rubick ;D

This was referenced Jun 13, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSghais @vikiival