Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

203 resources on last event query for rmrk2 #225

Merged

Conversation

Matehoo
Copy link
Contributor

@Matehoo Matehoo commented Apr 11, 2023

TODO:

  • Fix n+1 query with loader hacked the temporary solution for resolving n+1
  • Fix nft field
  • Fix meta field

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

Screenshot 2023-04-06 at 13 39 05

@kodabot
Copy link
Collaborator

kodabot commented Apr 11, 2023

WARNING @Matehoo PR for issue #203 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #203

@vikiival
Copy link
Member

Hey,
I just merged zlozenec into main + added prettier #226

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kjut, let's go

@vikiival vikiival merged commit 756c2b5 into kodadot:main Apr 11, 2023
@Matehoo Matehoo deleted the 203-resources-on-last-event-query-for-rmrk2 branch April 11, 2023 19:42
@vikiival vikiival added the V2 Implementation of RMRK::2.0.0 label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Implementation of RMRK::2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources on lastEvent query for rmrk2
3 participants