Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

169 no buy for you #171

Merged
merged 5 commits into from
Jan 9, 2023
Merged

169 no buy for you #171

merged 5 commits into from
Jan 9, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jan 6, 2023

  • πŸ”§ max root fields set for 50
  • ⚑ reverse engineer collection id
  • πŸ› fetching of collection from NFT

Thank you for your contribution to the KodaDot Indexer.
πŸ‘‡ _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

@vikiival vikiival requested a review from roiLeo January 6, 2023 17:27
@vikiival
Copy link
Member Author

vikiival commented Jan 6, 2023

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… wfm until KAN blocks
Capture d’écran 2023-01-09 aΜ€ 8 51 33 AM

@vikiival
Copy link
Member Author

vikiival commented Jan 9, 2023

until KAN blocks '
It means that you tried that until kan?

@roiLeo
Copy link
Contributor

roiLeo commented Jan 9, 2023

It means that you tried that until kan?

Yessir! Stopped at around block 6802508

@vikiival
Copy link
Member Author

vikiival commented Jan 9, 2023

Made issue to make DX more seamless

kodadot/packages#87

@vikiival vikiival merged commit 14e0827 into main Jan 9, 2023
@vikiival vikiival deleted the 169-no-buy-for-you branch January 9, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cached entities do not work
2 participants