-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ collection totalItems & updatedAt #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks for the PR!.
Make sure to test it and I would presonally changed the name
schema.graphql
Outdated
totalItems: Int! | ||
totalAvailableItems: Int! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totalItems: Int! | |
totalAvailableItems: Int! | |
nftCount: Int! | |
supply: Int! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't commit your suggestion as we will clearly need to recreate a migration file
nftCount
& supply
feels meh :/ (from the perspective of a dev I find it hard to tell the difference) but I'll change that
@roiLeo can you please run this query? query MyQuery {
collectionEntities(limit: 5, where: {nfts_some: {burned_eq: true}}) {
id
nftCount
supply
nfts {
id
burned
}
}
} |
to check if we count it correctly |
It comes from the consolidator saying that the entity needs to be real (exist) in DB to perform a buy. It is ok. |
Will go out with milestone 008 |
Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
updatedAt
field in collectiontotalItems
&totalAvailableitems
field in collectionBefore submitting Pull Request, please make sure:
Optional
Screenshot