Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚒️ exclude 0 value from floorprice #15

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 6, 2022

Will it blend too?

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/resolvers/series.ts Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

vikiival commented Jan 6, 2022

The question is: Do we need this? Does it break UI somehow?

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 6, 2022

The question is: Do we need this? Does it break UI somehow?

Well, floor_price has a great chance to be at 0 (new listed nft, see series stats), it would help to query (sort) HIGHEST/LOWEST floor_price

Co-authored-by: Viki Val <viktorko99@gmail.com>
@vikiival vikiival merged commit 1e4184d into kodadot:main Jan 6, 2022
@vikiival
Copy link
Member

vikiival commented Jan 6, 2022

release 06.01.2022 inb4 9pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants