Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: event group by nft_id #100

Merged
merged 2 commits into from
Jun 18, 2022
Merged

fix: event group by nft_id #100

merged 2 commits into from
Jun 18, 2022

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 18, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

Use group by to remove duplicate values.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

image

@Jarsen136 Jarsen136 mentioned this pull request Jun 18, 2022
Merged
17 tasks
vikiival
vikiival requested changes Jun 18, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol stuff otherwise oki

src/server-extension/query/event.ts Outdated Show resolved Hide resolved
vikiival
vikiival approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the form and we are good to go (updated pr description)

@Jarsen136
Copy link
Contributor Author

Please fill out the form and we are good to go (updated pr description)

Oki

@vikiival vikiival merged commit 9fe79fc into kodadot:main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarsen136 @vikiival