feat: rename moonsama to moonriver #3904

vikiival · 2022-09-02T12:56:21Z

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

Bugfix
Feature
Refactoring

What's new?

Updated

{
  "@kodadot1/vuex-options": "0.0.2"
}

netlify · 2022-09-02T12:56:28Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`06347a2`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/631b28790970d60008e16098
😎 Deploy Preview	https://deploy-preview-3904--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yangwao · 2022-09-02T13:11:40Z

yangwao · 2022-09-02T13:15:23Z

POST https://app.gc.subsquid.io/beta/click/001-rc0/graphql net::ERR_FAILED

in #3884 we have 🤔

click: 'https://squid.subsquid.io/click/v/001/graphql',

yangwao · 2022-09-02T13:56:05Z

wait for

yangwao · 2022-09-02T14:59:44Z

Something that could be tackled in

Cache (weird) bug on Firefox #3842

other than that seems it's up

yangwao · 2022-09-02T15:03:20Z

https://deploy-preview-3904--koda-nuxt.netlify.app/movr/explore?tab=GALLERY&page=1

{
    "errors": [
        {
            "message": "Variable \"$orderBy\" of type \"[NFTEntityOrderByInput]\" used in position expecting type \"[NFTEntityOrderByInput!]\".",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Variable \"$orderBy\" of type \"[NFTEntityOrderByInput]\" used in position expecting type \"[NFTEntityOrderByInput!]\".",
                        "    at Object.leave (/squid/node_modules/graphql/validation/rules/VariablesInAllowedPositionRule.js:55:35)",
                        "    at Object.leave (/squid/node_modules/graphql/language/visitor.js:344:29)",
                        "    at Object.leave (/squid/node_modules/graphql/utilities/TypeInfo.js:390:21)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}

…y into can-we-have-some-movr

yangwao · 2022-09-02T15:33:23Z

metadata on item detail?

https://deploy-preview-3904--koda-nuxt.netlify.app/movr/gallery/0x0dad866dc0c13fb8e4a91d1b5e83cf3a61d4cee2-7636

{
    "errors": [
        {
            "message": "Unknown type \"ID\".",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Unknown type \"ID\".",
                        "    at Object.NamedType (/squid/node_modules/graphql/validation/rules/KnownTypeNamesRule.js:57:29)",
                        "    at Object.enter (/squid/node_modules/graphql/language/visitor.js:323:29)",
                        "    at Object.enter (/squid/node_modules/graphql/utilities/TypeInfo.js:370:25)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at runMicrotasks (<anonymous>)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}

yangwao · 2022-09-02T15:34:28Z

Collection View

https://deploy-preview-3904--koda-nuxt.netlify.app/movr/collection/0xb6e9e605aa159017173caa6181c522db455f6661

{
    "errors": [
        {
            "message": "Unknown type \"ID\".",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Unknown type \"ID\".",
                        "    at Object.NamedType (/squid/node_modules/graphql/validation/rules/KnownTypeNamesRule.js:57:29)",
                        "    at Object.enter (/squid/node_modules/graphql/language/visitor.js:323:29)",
                        "    at Object.enter (/squid/node_modules/graphql/utilities/TypeInfo.js:370:25)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}

{
    "errors": [
        {
            "message": "Unknown type \"ID\".",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Unknown type \"ID\".",
                        "    at Object.NamedType (/squid/node_modules/graphql/validation/rules/KnownTypeNamesRule.js:57:29)",
                        "    at Object.enter (/squid/node_modules/graphql/language/visitor.js:323:29)",
                        "    at Object.enter (/squid/node_modules/graphql/utilities/TypeInfo.js:370:25)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at runMicrotasks (<anonymous>)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}

vikiival · 2022-09-03T14:58:06Z

vikiival · 2022-09-03T14:58:27Z

Best would be to downgrade click

yangwao · 2022-09-09T08:41:21Z

one random

otherwise, seems working?

yangwao · 2022-09-09T08:51:48Z

@petersopko let's check what's missing and what's needs to be done and update

MoonRiver & MoonBeam compatibility v0 #3647
accordingly with sub-issues

petersopko · 2022-09-09T09:14:51Z

collections don't show image previews+ errors in console
same for landing / curated lists
searching through explorer is hard / takes too long to load (sometimes it just gets stuck)

petersopko · 2022-09-09T09:16:52Z

holders/flippers:

vikiival · 2022-09-09T09:35:59Z

Balance is fixed in #3926

vikiival · 2022-09-09T09:40:00Z

@yangwao the issue is already there for 3 months #3338

petersopko · 2022-09-09T09:45:42Z

let's check what's missing and what's needs to be done and update
#3647
accordingly with sub-issues

@yangwao @vikiival I'm kind of confused about this PR, are we just renaming moonsama to moonriver, or fixing everything that's wrong with MOVR?

vikiival · 2022-09-09T09:48:00Z

Maybe just a bad issue #3902

yangwao · 2022-09-09T10:02:39Z

are we just renaming moonsama to moonriver,

yes

First batch of MoonRiver contracts #3902

or fixing everything that's wrong with MOVR?

also fixing rest once it's this minimum viable working version merged so others can continue

MoonRiver & MoonBeam compatibility v0 #3647

codeclimate · 2022-09-09T11:52:31Z

Code Climate has analyzed commit 06347a2 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	1

View more on Code Climate.

yangwao · 2022-09-09T12:32:12Z

fix tests here or merge it and fix them afterwards?

wyt @petersopko

petersopko · 2022-09-09T13:31:54Z

fix tests here or merge it and fix them afterwards?

wyt @petersopko

the failing tests here are the usual media tests

Longer timeout on media/audio ? #3812

I've hit re-run but regardless, I think it's save to merge

🔝 @kodadot1/vuex-options

dbde51b

vikiival requested review from a team as code owners September 2, 2022 12:56

vikiival requested review from Jarsen136 and damskyftw and removed request for a team September 2, 2022 12:56

vikiival enabled auto-merge September 2, 2022 12:56

vikiival linked an issue Sep 2, 2022 that may be closed by this pull request

First batch of MoonRiver contracts #3902

Closed

yangwao changed the title ~~feat: rename mooonbeam to moonriver~~ feat: rename moonsama to moonriver Sep 2, 2022

Merge branch 'main' into can-we-have-some-movr

34685b7

Jarsen136 approved these changes Sep 2, 2022

View reviewed changes

Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 2, 2022

yangwao mentioned this pull request Sep 2, 2022

Disable Statemine route from tests #3905

Closed

vikiival and others added 7 commits September 2, 2022 16:24

📦 @kodadot1/vuex-options@0.0.3-rc.1

672bc26

🚚 rename moonsama to movr

9b6eb01

wtf is isMoonsama

8ca5348

⚡ enable moonriver

13f5a0a

🚚 rename moonsama to movr

e09d78c

⚡ use click with movr contracts

8b3abe6

Merge branch 'main' into can-we-have-some-movr

5778c3a

vikiival added 2 commits September 2, 2022 17:12

🐛 bad type on the query

94003de

Merge branch 'can-we-have-some-movr' of github.com:kodadot/nft-galler…

1204672

…y into can-we-have-some-movr

yangwao marked this pull request as draft September 5, 2022 11:00

auto-merge was automatically disabled September 5, 2022 11:00
Pull request was converted to draft

yangwao added the A-moonriver issues related to MoonRiver network label Sep 7, 2022

Merge branch 'main' into can-we-have-some-movr

c0f4892

yangwao marked this pull request as ready for review September 9, 2022 08:50

yangwao requested review from petersopko and removed request for damskyftw September 9, 2022 08:50

yangwao mentioned this pull request Sep 9, 2022

Update links for MoonRiver to point on TXN hash rather block #3931

Closed

Merge branch 'main' into can-we-have-some-movr

1e31b07

petersopko mentioned this pull request Sep 9, 2022

Trait boxes on 📱 #3932

Closed

Merge branch 'main' into can-we-have-some-movr

06347a2

yangwao merged commit 3c170f1 into main Sep 9, 2022

yangwao deleted the can-we-have-some-movr branch September 9, 2022 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rename moonsama to moonriver #3904

feat: rename moonsama to moonriver #3904

vikiival commented Sep 2, 2022 •

edited by yangwao

Loading

netlify bot commented Sep 2, 2022 •

edited

Loading

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022 •

edited

Loading

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022 •

edited

Loading

vikiival commented Sep 3, 2022

vikiival commented Sep 3, 2022 •

edited

Loading

yangwao commented Sep 9, 2022

yangwao commented Sep 9, 2022

petersopko commented Sep 9, 2022

petersopko commented Sep 9, 2022

vikiival commented Sep 9, 2022 •

edited

Loading

vikiival commented Sep 9, 2022

petersopko commented Sep 9, 2022

vikiival commented Sep 9, 2022

yangwao commented Sep 9, 2022

codeclimate bot commented Sep 9, 2022

yangwao commented Sep 9, 2022

petersopko commented Sep 9, 2022

feat: rename moonsama to moonriver #3904

feat: rename moonsama to moonriver #3904

Conversation

vikiival commented Sep 2, 2022 • edited by yangwao Loading

PR type

Related

What's new?

netlify bot commented Sep 2, 2022 • edited Loading

✅ Deploy Preview for koda-nuxt ready!

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022 • edited Loading

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022

yangwao commented Sep 2, 2022 • edited Loading

vikiival commented Sep 3, 2022

vikiival commented Sep 3, 2022 • edited Loading

yangwao commented Sep 9, 2022

yangwao commented Sep 9, 2022

petersopko commented Sep 9, 2022

petersopko commented Sep 9, 2022

vikiival commented Sep 9, 2022 • edited Loading

vikiival commented Sep 9, 2022

petersopko commented Sep 9, 2022

vikiival commented Sep 9, 2022

yangwao commented Sep 9, 2022

codeclimate bot commented Sep 9, 2022

yangwao commented Sep 9, 2022

petersopko commented Sep 9, 2022

vikiival commented Sep 2, 2022 •

edited by yangwao

Loading

netlify bot commented Sep 2, 2022 •

edited

Loading

yangwao commented Sep 2, 2022 •

edited

Loading

yangwao commented Sep 2, 2022 •

edited

Loading

vikiival commented Sep 3, 2022 •

edited

Loading

vikiival commented Sep 9, 2022 •

edited

Loading