Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3d objects are not showing on landing #3786

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 19, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested review from a team as code owners August 19, 2022 01:01
@Jarsen136 Jarsen136 requested review from kkukelka and DeluneClaire and removed request for a team August 19, 2022 01:01
@kodabot
Copy link
Collaborator

kodabot commented Aug 19, 2022

WARNING @Jarsen136 PR for issue #3767 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3767

@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 27573d7
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62fee103f6353400092f90a6
😎 Deploy Preview https://deploy-preview-3786--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Aug 19, 2022

Code Climate has analyzed commit 27573d7 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@kkukelka kkukelka added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 19, 2022
@yangwao
Copy link
Member

yangwao commented Aug 19, 2022

nice!
pay 50

image

@yangwao
Copy link
Member

yangwao commented Aug 19, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 48.19 USD/KSM ~ 1.038 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xfc6b8005e83271ddcf5bd62fdc6274028b8c96ca16220ee9c50c205435aad9fa

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 19, 2022
@yangwao yangwao merged commit e3942ef into kodadot:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3d objects are not showing in latest sales on landing?
4 participants