Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bsx landing page add lastest and newest list #3693

Merged
merged 6 commits into from
Aug 11, 2022

Conversation

zhengow
Copy link
Contributor

@zhengow zhengow commented Aug 7, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at http://localhost:9090/
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@zhengow zhengow requested review from a team as code owners August 7, 2022 07:54
@zhengow zhengow requested review from kkukelka and JustLuuuu and removed request for a team August 7, 2022 07:54
@netlify
Copy link

netlify bot commented Aug 7, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 9165dcd
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62f3b2441753e60008cf0ec9
😎 Deploy Preview https://deploy-preview-3693--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zhengow
Copy link
Contributor Author

zhengow commented Aug 7, 2022

Do I need to show popular collection list for bsx? Currently I hide it because there is no issue for it.

<div v-if="prefix === 'rmrk' || prefix === 'bsx'">
        <LazyGalleryLatestSales class="my-5" />
        <LazyGalleryPopularCollections class="my-5" />
        <span v-if="prefix === 'rmrk'">
          <LazyGalleryPopularCollections class="my-5" />
        </span>
        <LazyGalleryNewestList class="my-5" />
</div>

@yangwao
Copy link
Member

yangwao commented Aug 7, 2022

Do I need to show popular collection list for bsx?

I think once we will be live we can show some popular collections :)
I can make an issue for that tho

@zhengow
Copy link
Contributor Author

zhengow commented Aug 7, 2022

Do I need to show popular collection list for bsx?

I think once we will be live we can show some popular collections :) I can make an issue for that tho

Actually I find this one needs to write another resolver about seriesInsightTable, maybe it can be solved in another MR:)

Copy link
Member

@JustLuuuu JustLuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@JustLuuuu JustLuuuu added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 8, 2022
@petersopko
Copy link
Contributor

@zhengow can't we use the same query for the bsx/rmrk? seems like an overkill in the code 👀 if the passionAccount thing causes problems, we can throw it out for now as we have disabled passion feed anyways

@petersopko petersopko added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 8, 2022
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more KISS pls 💋 😆

@zhengow
Copy link
Contributor Author

zhengow commented Aug 8, 2022

@zhengow can't we use the same query for the bsx/rmrk? seems like an overkill in the code 👀 if the passionAccount thing causes problems, we can throw it out for now as we have disabled passion feed anyways

Sure, more kiss 💋 now:)

@petersopko
Copy link
Contributor

👀
image

@zhengow
Copy link
Contributor Author

zhengow commented Aug 9, 2022

👀 image

Fix it!
image
image

@yangwao
Copy link
Member

yangwao commented Aug 10, 2022

good to go?

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2022

Code Climate has analyzed commit 9165dcd and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg from my pov

@yangwao
Copy link
Member

yangwao commented Aug 11, 2022

pay 150

@yangwao
Copy link
Member

yangwao commented Aug 11, 2022

😍 Perfect, I’ve sent the payout
💵 $150 @ 63.45 USD/KSM ~ 2.364 $KSM
🧗 EgCzZLpVe7zg7RHh79qPyC8UrykVkA22YY2oj7sWMZf15Ws
🔗 0x8452ce837615025939526c3fc9348985df0d4b5825888e181c2a1b4a89ebc1fe

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 11, 2022
@yangwao yangwao merged commit 1570c98 into kodadot:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest sales for Basilsik Newest List for Basilisk
5 participants