-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basilisk NFT Marketplace #3060
Basilisk NFT Marketplace #3060
Conversation
# Conflicts: # components/rmrk/Gallery/CollectionItem.vue # pnpm-lock.yaml
# Conflicts: # components/rmrk/Gallery/CollectionItem.vue
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
…y into 660-non-fungible-snek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
103/103
Time to merge as lots of conflicts will arise 🥵 @vikiival |
Snekk is verry happy for you @yangwao |
# Conflicts: # components/base/CarouselCardList.vue # components/common/WalletModal.vue # components/rmrk/Gallery/Gallery.vue # components/rmrk/Gallery/GalleryItem.vue # langDir/en.json # pages/rmrk/collection/_id.vue # pnpm-lock.yaml
@@ -156,6 +156,7 @@ | |||
owned: true, | |||
priceMin: undefined, | |||
priceMax: undefined, | |||
owned: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-dupe-keys> reported by reviewdog 🐶
Duplicate key 'owned'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooof 🐶
this might be an issue with ss58? Does direct URL seem work https://deploy-preview-3060--koda-nuxt.netlify.app/bsx/collection/2224622395?page=1 Error happened between going to artists profile https://deploy-preview-3060--koda-nuxt.netlify.app/bsx/u/bXjmyHufR6HcjAtKNVTV4UjHj3poQW3d2yYWKDdWe5cGGmg3z?page=1
|
Hey as there are a lot of post reviews, we would like to split load off @vikiival head and we want to speed up BSX integration. Feel free to take a peek at PRs conversations, which weren't resolved. 🐍 Found one thing that needs to be fixed, asap so someone could feel free to take charge of that. |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional