Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basilisk NFT Marketplace #3060

Merged
merged 153 commits into from
Jun 8, 2022
Merged

Basilisk NFT Marketplace #3060

merged 153 commits into from
Jun 8, 2022

Conversation

vikiival
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

# Conflicts:
#	components/rmrk/Gallery/CollectionItem.vue
#	pnpm-lock.yaml
# Conflicts:
#	components/rmrk/Gallery/CollectionItem.vue
vikiival and others added 2 commits May 26, 2022 16:27
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
Copy link
Contributor

@KngZhi KngZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

103/103

components/bsx/Gallery/Item/AvailableActions.vue Outdated Show resolved Hide resolved
components/bsx/Gallery/Item/GalleryItem.vue Outdated Show resolved Hide resolved
components/bsx/Gallery/Item/GalleryItem.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/Gallery.vue Show resolved Hide resolved
components/rmrk/Gallery/Item/ActionList.vue Show resolved Hide resolved
nuxt.config.js Outdated Show resolved Hide resolved
pages/bsx/detail/_id.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Jun 2, 2022

Time to merge as lots of conflicts will arise 🥵 @vikiival
We can follow up with fine-tuning for Basilisk in the next PR 😛

image

@vikiival
Copy link
Member Author

vikiival commented Jun 2, 2022

Snekk is verry happy for you @yangwao

Screenshot 2022-06-02 at 17 28 54

@yangwao yangwao marked this pull request as ready for review June 2, 2022 15:52
# Conflicts:
#	components/base/CarouselCardList.vue
#	components/common/WalletModal.vue
#	components/rmrk/Gallery/Gallery.vue
#	components/rmrk/Gallery/GalleryItem.vue
#	langDir/en.json
#	pages/rmrk/collection/_id.vue
#	pnpm-lock.yaml
@@ -156,6 +156,7 @@
owned: true,
priceMin: undefined,
priceMax: undefined,
owned: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-dupe-keys> reported by reviewdog 🐶
Duplicate key 'owned'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooof 🐶

@yangwao
Copy link
Member

yangwao commented Jun 6, 2022

@yangwao
Copy link
Member

yangwao commented Jun 8, 2022

this might be an issue with ss58?
I switched to BSX and showed 2 while the BSX testnet should be 10041 ?

image

Does direct URL seem work https://deploy-preview-3060--koda-nuxt.netlify.app/bsx/collection/2224622395?page=1

Error happened between going to artists profile https://deploy-preview-3060--koda-nuxt.netlify.app/bsx/u/bXjmyHufR6HcjAtKNVTV4UjHj3poQW3d2yYWKDdWe5cGGmg3z?page=1
but seems items are being shown

image

{
    "errors": [
        {
            "message": "Cannot query field \"nFTEntities\" on type \"Query\". Did you mean \"nftEntities\" or \"nftEntityById\"?",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Cannot query field \"nFTEntities\" on type \"Query\". Did you mean \"nftEntities\" or \"nftEntityById\"?",
                        "    at Object.Field (/squid/node_modules/graphql/validation/rules/FieldsOnCorrectTypeRule.js:48:31)",
                        "    at Object.enter (/squid/node_modules/graphql/language/visitor.js:323:29)",
                        "    at Object.enter (/squid/node_modules/graphql/utilities/TypeInfo.js:370:25)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at runMicrotasks (<anonymous>)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}

@yangwao
Copy link
Member

yangwao commented Jun 8, 2022

Hey as there are a lot of post reviews, we would like to split load off @vikiival head and we want to speed up BSX integration.

Feel free to take a peek at PRs conversations, which weren't resolved.
Help to contribute and coordinate and put label Basilisk or BSX prefix to name for the PRs so we can merge it to main.

🐍

Found one thing that needs to be fixed, asap so someone could feel free to take charge of that.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-basilisk issues related to basilisk parachain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basilisk v0.1
5 participants