Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(2918): subsquid for ProfileDetail #2975

Merged
merged 44 commits into from
May 22, 2022

Conversation

KngZhi
Copy link
Contributor

@KngZhi KngZhi commented May 8, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@KngZhi KngZhi requested a review from a team as a code owner May 8, 2022 08:41
@KngZhi KngZhi requested review from roiLeo and removed request for a team May 8, 2022 08:41
@kodabot
Copy link
Collaborator

kodabot commented May 8, 2022

WARNING @KngZhi PR for issue #2918 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #2918

@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c370bbd
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/628909416821e50009a95e48
😎 Deploy Preview https://deploy-preview-2975--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KngZhi KngZhi changed the title refactor: subsquid for ProfileDetail refactor(2918): subsquid for ProfileDetail May 8, 2022
@vikiival
Copy link
Member

vikiival commented May 8, 2022

@KngZhi
#2918 (comment)

@KngZhi
Copy link
Contributor Author

KngZhi commented May 8, 2022

@KngZhi

#2918 (comment)

okay, out of computer, will update soon.

@vikiival vikiival mentioned this pull request May 8, 2022
89 tasks
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • searchbar in profile don't seem to work
  • your changes in PaginatedCardList could break other chain (statemin, westmint)
  • could you add fragments in your queries? it will make it easier to read
  • where emotes? added in ✨ show emoteCount & sort by most reacted  #2936

queries/rmrk/subsquid/general/nftListSold.graphql Outdated Show resolved Hide resolved
queries/rmrk/subsquid/general/nftListSold.graphql Outdated Show resolved Hide resolved
queries/rmrk/subsquid/general/nftListSold.graphql Outdated Show resolved Hide resolved
queries/rmrk/subsquid/general/nftListCollected.graphql Outdated Show resolved Hide resolved
queries/rmrk/subsquid/general/nftListCollected.graphql Outdated Show resolved Hide resolved
queries/rmrk/subsquid/general/nftListCollected.graphql Outdated Show resolved Hide resolved
queries/rmrk/subsquid/general/nftListCollected.graphql Outdated Show resolved Hide resolved
components/rmrk/Gallery/PaginatedCardList.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/PaginatedCardList.vue Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

TBH I would just close both :)

@KngZhi
Copy link
Contributor Author

KngZhi commented May 12, 2022

@roiLeo

  1. searchbar in profile don't seem to work

Fixed with that. But another issue come up, subsquid seems does not to support case-insensitive name query.

Rubick totalCount 8, you will get another 4 counts for L name query
image

Magic totalCount 12
image

@roiLeo
Copy link
Contributor

roiLeo commented May 12, 2022

@roiLeo

  1. searchbar in profile don't seem to work

Fixed with that. But another issue come up, subsquid seems does not to support case-insensitive name query.

#2951 might help you

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 12, 2022
@KngZhi
Copy link
Contributor Author

KngZhi commented May 17, 2022

@KngZhi

I did a final test before merging and found that it was not possible to search in user "Sold" tab, same with "BUY NOW" filter. Sorting is working.

Capture d’écran 2022-05-17 à 2 03 08 PM

could you take a look?

hmmm, okay! I will check that.

@KngZhi
Copy link
Contributor Author

KngZhi commented May 17, 2022

deployed version

Screen.Recording.2022-05-17.at.10.47.23.PM.mov

@KngZhi KngZhi requested review from vikiival and roiLeo May 17, 2022 14:49
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing emotes added in #2936 & sort by emotes count

Beta

Capture d’écran 2022-05-18 à 10 54 41 AM

Preview

Capture d’écran 2022-05-18 à 10 55 12 AM

@KngZhi
Copy link
Contributor Author

KngZhi commented May 18, 2022

🫡 I'll check every corner, sir.

@KngZhi
Copy link
Contributor Author

KngZhi commented May 18, 2022

for the current subsquid, it does not have the field emotes: { totalCount } therefore it was unable to sortBy with that, we have to extend or found a workaround.

@vikiival any idea for how to do that? I check with subsquid official doc and magic repo, haven't found any clue.

@vikiival
Copy link
Member

I would skip that for now :)

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol stuff

components/rmrk/Gallery/PaginatedCardList.vue Show resolved Hide resolved
components/rmrk/Gallery/History.vue Show resolved Hide resolved
components/rmrk/Profile/ProfileDetail.vue Outdated Show resolved Hide resolved
@KngZhi
Copy link
Contributor Author

KngZhi commented May 21, 2022

I would skip that for now :)

if so, I would suggest we comment that option out for now.

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope to merge this today 🤞

pages/statemine/u/_id.vue Outdated Show resolved Hide resolved
pages/statemine/u/_id.vue Outdated Show resolved Hide resolved
pages/westmint/u/_id.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/History.vue Show resolved Hide resolved
@KngZhi
Copy link
Contributor Author

KngZhi commented May 21, 2022

Out of computer, will be back soon.

@KngZhi
Copy link
Contributor Author

KngZhi commented May 21, 2022

this.client does not support on test net, it would fetch https://api.subquery.network/sq/kodadot/unique.

@vikiival
Copy link
Member

test net

:D Unique is implementation of Statemine, it's not a testnet
But do not worry about that :)

@vikiival
Copy link
Member

@vikiival vikiival merged commit 92d959d into kodadot:main May 22, 2022
@vikiival
Copy link
Member

pay 250 usd

@yangwao
Copy link
Member

yangwao commented May 22, 2022

😍 Perfect, I’ve sent the payout
💵 $250 @ 81.06 USD/KSM ~ 3.084 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0x6e7ef84695d2bb4db3ead4e9af3c9bfe2de8069e76c500cfb4275da6cc3d8157

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 22, 2022
@KngZhi KngZhi deleted the issue-2918-rewritten-subsquid branch May 22, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

History tab in user Profil don't show any amount use 'subsquid' query in profile tabs
5 participants