Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip netlify] kodabot #2914

Merged
merged 3 commits into from
May 1, 2022
Merged

[skip netlify] kodabot #2914

merged 3 commits into from
May 1, 2022

Conversation

petersopko
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@petersopko petersopko requested a review from a team as a code owner April 28, 2022 08:48
@petersopko petersopko requested review from kkukelka and removed request for a team April 28, 2022 08:48
@kodabot
Copy link
Collaborator

kodabot commented Apr 28, 2022

WARNING @petersopko PR for issue #1477 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #1477

@petersopko
Copy link
Contributor Author

@yangwao sorry, I saw you've requested review on the old PR I just opened up a new one with updated file to avoid reverting/merge conflicts etc.

@petersopko petersopko requested a review from yangwao April 28, 2022 08:52
vikiival
vikiival approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangwao
Copy link
Member

yangwao commented May 1, 2022

pay 2000 usd

2 similar comments
@yangwao
Copy link
Member

yangwao commented May 1, 2022

pay 2000 usd

@yangwao
Copy link
Member

yangwao commented May 1, 2022

pay 2000 usd

@yangwao
Copy link
Member

yangwao commented May 1, 2022

😍 Perfect, I’ve sent the payout
💵 $2000 @ 133.68 USD/KSM ~ 14.961 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x628cb66f1259c45564a64853a23d0ae83bc93a1cf5459bc16c39e670b83b500c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 1, 2022
@yangwao yangwao merged commit 2bafc26 into kodadot:main May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@kkukelka kkukelka Awaiting requested review from kkukelka kkukelka is a code owner automatically assigned from kodadot/code-review-guild

@yangwao yangwao Awaiting requested review from yangwao

Assignees
No one assigned
Labels
paid pull-request has been paid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Payout leaderboard for KodaDot
4 participants
@petersopko @kodabot @yangwao @vikiival