Database split part II: KobocatDeploymentBackend refactoring #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entBackend' and 'SubmissionViewSet'. Unittests
… asset (before triggerring the hook)
noliveleger
changed the title
noliveleger
changed the title
jnm
reviewed
May 21, 2019
jnm
reviewed
May 22, 2019
There was a problem hiding this comment.
unfinished review; submitting so @noliveleger can see my comments
| prepared_drf_response["data"] = json.loads(requests_response.content) | ||
| except ValueError as e: | ||
| if not requests_response.status_code == status.HTTP_204_NO_CONTENT: | ||
| raise Exception(str(e)) |
There was a problem hiding this comment.
- Would it be better to re-raise a
ValueErrorinstead of a genericException? - Maybe
str(e)should be prefixed with "KoBoCAT returned an unexpected response: " or similar (to avoid the unhelpfulNo JSON object could be decodedmessage that people get in the current release)
There was a problem hiding this comment.
I have changed the code a little bit.
The error is returned in the response. FE can expose the message to users.
For example, if submission deletion fails, nothing happens. It would be better to display a message to users. (cc @magicznyleszek)
kpi/tests/test_api_submissions.py
Outdated
|
|
||
| class SubmissionApiTests(BaseTestCase): | ||
|
|
||
| def test_create_submission(self): |
There was a problem hiding this comment.
Let's say test_cannot_create_submission
kpi/tests/test_api_submissions.py
Outdated
|
|
||
| def test_delete_submission_shared_other_write(self): | ||
| self._other_user_login(True) | ||
| self.asset.assign_perm(self.anotheruser, "change_submissions") |
kpi/tests/test_api_submissions.py
Outdated
| "pk": self.submission.get("id") | ||
| }) | ||
|
|
||
| def test_trigger_signal(self): |
There was a problem hiding this comment.
Bad test name. Nothing related to signal. I have renamed it.
I also noticed that few others tests were missing (e.g. get edit link for viewers only), so I added them.
jnm
reviewed
May 22, 2019
noliveleger
force-pushed
the
refactor-kobocat-deployment-backend
branch
from
353d6da
to
f728b9c
Compare
… KobocatBackend.get_submissions()
jnm
requested changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2155.
Fixes #2036
Because some parts of the code in
KobocatDeploymentBackendandKobocatDataProxyViewSetMixinwere doing the same thing,KobocatDeploymentBackendhas been refactoring to regroup all the logic forkcproxy.Even
SubmissionViewSethas been refactored to use new methods ofKobocatDeploymentBackendand to benefit PROs of DRF (permissions, renderers)A new viewset has been created to handle hook signals from
kobocat(Don't merge until kobotoolbox/kobocat#523 is reviewed and merged too)