Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest subset fields #2016

Merged
merged 32 commits into from
Oct 9, 2018
Merged

Rest subset fields #2016

merged 32 commits into from
Oct 9, 2018

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Sep 28, 2018 •
edited
Loading

Based on #2015.
Last PR (or 3).
Let the users choose which fields they want to send to remote endpoints

There are FE and BE changes.

noliveleger and others added 18 commits September 5, 2018 17:23
@noliveleger
Send only subset of fields to remote Server for JSON hooks
aef5338
@noliveleger
Refactoring: Changed 'filtered_fields' to 'subset_fields'
f178159
@noliveleger
Refactoring: Changed 'filtered_fields' to 'subset_fields' - forgotten…
59f367f 
… occurrences
@magicznyleszek
user final prop name
7574c3e
@noliveleger
Added XML parser for subset of fields
0c36180
@noliveleger
Merge branch 'rest_subset_fields' of github.com:kobotoolbox/kpi into …
0d5e38e 
…rest_subset_fields
@noliveleger
Added unittests for XML parsing
4c27419
@noliveleger
Updated json parser test
eedac96
@noliveleger
Merged rest_email_notification branch into rest_subset_fields
c0c8cc2
@noliveleger
Fixed bad merge
92ce1e4
@noliveleger
Stop exposing asset_id in Hook Viewset
1653cb5
@magicznyleszek
remove dev fallbacks
5db4246
@magicznyleszek
add / to api calls
f00ac2c
@noliveleger
Updated API doc
16f3da8
@noliveleger
Merge branch 'rest_subset_fields' of github.com:kobotoolbox/kpi into …
5b5eb82 
…rest_subset_fields
@noliveleger
Merge branch 'rest_email_notification' into rest_subset_fields
d8b45fa
@noliveleger
Merge rest_email_notification branch into rest_subset_field
e2188e1
@noliveleger
Merged rest_email_notification branch into rest_subset_fields
94f8003
@noliveleger noliveleger mentioned this pull request Oct 1, 2018
Closed
jnm
jnm requested changes Oct 3, 2018
View reviewed changes
Copy link
Member

@jnm jnm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you already made some changes to this, but I don't see a way to move a review in progress to the tip of the branch. I'll look after I submit the review to see which parts of it are outdated. I think my comments still apply.

kobo/apps/hook/services/service_xml.py Outdated Show resolved Hide resolved
kobo/apps/hook/services/service_xml.py Show resolved Hide resolved
kobo/apps/hook/tests/hook_test_case.py Outdated Show resolved Hide resolved
kobo/apps/hook/tests/hook_test_case.py Outdated Show resolved Hide resolved
kobo/apps/hook/tests/hook_test_case.py Outdated Show resolved Hide resolved
@jnm jnm merged commit 6ce1c0b into rest_email_notification Oct 9, 2018
@jnm jnm deleted the rest_subset_fields branch October 9, 2018 23:06
This was referenced Oct 9, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm approved these changes

@pmusaraj pmusaraj Awaiting requested review from pmusaraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noliveleger @jnm @magicznyleszek