Fix missing x-Axis on 1D Timeframe #774
Conversation
|
@timmolter @mccartney This is an important fix for us over at openHAB, is there any chance this could be merged and a new release could be made within the next week? I would really appreciate it, thanks a lot for all the effort! |
Flole998
force-pushed
the
fix-xaxis-date
branch
2 times, most recently
from
21e81d1
to
5aa2b93
Compare
|
Thanks a lot! And yes, but the entire codebase needs cleaning up. Especially all those Print-Statements that are commented out should be based on some global variable to turn them on and off easily. This function has been "tweaked" many times apparently and it's probably better to understand it and then rewrite it based on what it should do instead of trying to fix it again and again (although I think it's finally "good" now). It might even make sense to split parts of it into a new function. |
Famous last words :) |
|
@timmolter Any chance we could get a new release soon? On the last release at least a 24 hour timespan on an axis is broken and causes the axis to disappear (which is a regression), and with this "Hotfix" included that issue would be gone again. |
|
yes, this week sometime. Any other PRs you want to merge @mccartney ? |
|
No, thanks. I am good |
|
I'll push a release tomorrow. |
Unfortunately the fix from #717 caused the Axis to disappear in certain cases (for example when a Timeframe of 1d was used). This fix is better as it goes back to the first attempt and then ignores if the labels are not unique. It is mentioned in the code that usually the first one works alright, so in case we didn't find anything better we should use the first one as a fallback and not the last one as in my original fix.