Skip to content

Commit

Permalink
Fix linter issues
Browse files Browse the repository at this point in the history
  • Loading branch information
creydr committed Jun 14, 2024
1 parent dc8a49a commit 87dc325
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 4 deletions.
4 changes: 2 additions & 2 deletions apis/duck/v1/auth_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ func (*AuthStatus) GetFullType() ducktypes.Populatable {
}

// ConvertTo implements apis.Convertible
func (a *AuthStatus) ConvertTo(ctx context.Context, to apis.Convertible) error {
func (a *AuthStatus) ConvertTo(_ context.Context, to apis.Convertible) error {
return fmt.Errorf("v1 is the highest known version, got: %T", to)
}

// ConvertFrom implements apis.Convertible
func (a *AuthStatus) ConvertFrom(ctx context.Context, from apis.Convertible) error {
func (a *AuthStatus) ConvertFrom(_ context.Context, from apis.Convertible) error {
return fmt.Errorf("v1 is the highest known version, got: %T", from)
}

Expand Down
4 changes: 2 additions & 2 deletions resolver/authenticatable_resolver.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/*
Copyright 2019 The Knative Authors
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
http://www.apache.org/licenses/LICENSE-2.0

Check failure on line 8 in resolver/authenticatable_resolver.go

View workflow job for this annotation

GitHub Actions / style / Golang / Boilerplate Check (go)

[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: resolver/authenticatable_resolver.go:8: found mismatched boilerplate lines: {[]string}[0]: -: " http://www.apache.org/licenses/LICENSE-2.0" +: "\thttp://www.apache.org/licenses/LICENSE-2.0"
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
16 changes: 16 additions & 0 deletions resolver/authenticatable_resolver_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0

Check failure on line 8 in resolver/authenticatable_resolver_test.go

View workflow job for this annotation

GitHub Actions / style / Golang / Boilerplate Check (go)

[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: resolver/authenticatable_resolver_test.go:8: found mismatched boilerplate lines: {[]string}[0]: -: " http://www.apache.org/licenses/LICENSE-2.0" +: "\thttp://www.apache.org/licenses/LICENSE-2.0"
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package resolver_test

import (
Expand Down

0 comments on commit 87dc325

Please sign in to comment.