guard other variables from the effect of setf #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alistの内容を
setf
で変更すると、引数で渡した側の変数の内容も変更されてしまいます。例えば、以下のようになってしまうので、
現状だと、
wmvc:build-buffer
に渡す変数をcopy-alist
などで守る必要が出てきます。仮に、この挙動を把握して実装されていたとしても、
(elispに対しての理解が浅い)ユーザ側に対して優しくない設計だと思うので、
setf
による変更が外部に波及しないようにしました。wmvc:context-attr-set
で、copy-alist
を使っていないのは、その方が論理的に処理に沿っているし、メモリ消費的にも良いのではと思ったので。