Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: rm virtualenv, already using python3 -m venv #1515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dependencies: rm virtualenv, already using python3 -m venv #1515

wants to merge 1 commit into from

Commits on Oct 14, 2022

  1. dependencies: rm 'virtualenv', already using "python3 -m venv" 

    This PR removes the `virtualenv` dependency from `setup.py`, as it looks redundant.

To be fair, I am not fully certain why setup.py was declaring `virtualenv` as needed,
I think it's a historical remnant of python 2 days.

The min required python version is atm 3.6:
https://github.com/kivy/buildozer/blob/9503f5fd153f3f08e9160799fc04b23faf6aabeb/setup.py#L16
`venv` is part of the stdlib since python 3.3, and "is now recommended for creating virtual environments" since 3.5:
https://docs.python.org/3/library/venv.html
Note that `venv` is a subset of `virtualenv`, but buildozer AFAICT is only using that subset.

Similar change in p4a:
kivy/python-for-android#2152
    @SomberNight
    SomberNight committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    1602696 View commit details
    Browse the repository at this point in the history