Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix harvesting CLI #127

Merged
merged 27 commits into from
May 3, 2023
Merged

Add prefix harvesting CLI #127

merged 27 commits into from
May 3, 2023

Conversation

Pfeil
Copy link
Member

@Pfeil Pfeil commented Apr 6, 2023

  • Add possibility to get all PIDs of the configured prefix to PID system adapters
  • Add CLI options to trigger bootstrap or csv/list output. Options considered:
    • bootstrap all-pids-from-prefix
      • Would start the PID Maker and read all PIDs from the prefix to handle it according to the settings: send messages, store as known PID, directly store in Elasticsearch (coming soon(TM))
    • bootstrap known-pids
      • Same as above but only with known PIDs (useful to spread all known PIDs to the message broker again).
    • write-file all-pids-from-prefix
      • Reads all PIDs from the prefix, stores it in a file, and stops the Typed PID Maker.
    • write-file known-pids
      • Same as above, but restricted to the "known PIDs" (PIDs which are, depending on configuration, created/modified/resolved using this instance, or have been bootstrapped).
  • Test manually the Handle Protocol version, as automated testing is not practical due to access restriction and PID management
  • Documentation in Readme
  • Prepare PR for webpage documentation and news post in Typed pid maker version 1.1.0 webpage#32
  • store a list of our production PIDs in bws&s
  • add unit/integration tests
  • Wait for Add search endpoint #128 , then:
    • merge master in here
    • include indexing on bootstrap

@coveralls
Copy link

coveralls commented Apr 6, 2023

Pull Request Test Coverage Report for Build #213

  • 73 of 224 (32.59%) changed or added relevant lines in 10 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 58.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleSystemRESTAdapter.java 0 1 0.0%
src/main/java/edu/kit/datamanager/pit/pitservice/impl/TypingService.java 0 1 0.0%
src/main/java/edu/kit/datamanager/pit/cli/CliTaskBootstrap.java 29 38 76.32%
src/main/java/edu/kit/datamanager/pit/cli/CliTaskWriteFile.java 12 26 46.15%
src/main/java/edu/kit/datamanager/pit/configuration/HandleCredentials.java 0 15 0.0%
src/main/java/edu/kit/datamanager/pit/Application.java 0 52 0.0%
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java 9 68 13.24%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/kit/datamanager/pit/Application.java 2 38.71%
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java 2 20.83%
Totals Coverage Status
Change from base Build #211: 0.3%
Covered Lines: 935
Relevant Lines: 1597

💛 - Coveralls

@sonatype-lift

This comment was marked as outdated.

@Pfeil Pfeil linked an issue Apr 11, 2023 that may be closed by this pull request
@Pfeil Pfeil force-pushed the add-prefix-harvesting-cli branch from 42eb44c to db44b04 Compare April 12, 2023 07:42
@Pfeil Pfeil added the enhancement New feature or request label Apr 12, 2023
@Pfeil Pfeil added this to the 1.1.0 milestone Apr 19, 2023
@Pfeil Pfeil force-pushed the add-prefix-harvesting-cli branch from 2bc2be9 to aefd643 Compare April 21, 2023 10:06
@Pfeil
Copy link
Member Author

Pfeil commented Apr 24, 2023

  • fixed: CI fails due to tighter restrictions to file names on windows.
  • checked / fixed: On bootstrap, make sure known PIDs that are already in there do not get their date reset.

@Pfeil Pfeil marked this pull request as ready for review May 3, 2023 10:32
@Pfeil Pfeil merged commit 9910c91 into master May 3, 2023
@Pfeil Pfeil deleted the add-prefix-harvesting-cli branch July 31, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to re-send known PIDs to message broker on certain occasions.
2 participants