-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix harvesting CLI #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Pfeil
commented
Apr 6, 2023
•
edited
Loading
edited
- Add possibility to get all PIDs of the configured prefix to PID system adapters
- Add CLI options to trigger bootstrap or csv/list output. Options considered:
- bootstrap all-pids-from-prefix
- Would start the PID Maker and read all PIDs from the prefix to handle it according to the settings: send messages, store as known PID, directly store in Elasticsearch (coming soon(TM))
- bootstrap known-pids
- Same as above but only with known PIDs (useful to spread all known PIDs to the message broker again).
- write-file all-pids-from-prefix
- Reads all PIDs from the prefix, stores it in a file, and stops the Typed PID Maker.
- write-file known-pids
- Same as above, but restricted to the "known PIDs" (PIDs which are, depending on configuration, created/modified/resolved using this instance, or have been bootstrapped).
- bootstrap all-pids-from-prefix
- Test manually the Handle Protocol version, as automated testing is not practical due to access restriction and PID management
- Documentation in Readme
- Prepare PR for webpage documentation and news post in Typed pid maker version 1.1.0 webpage#32
- store a list of our production PIDs in bws&s
- add unit/integration tests
- Wait for Add search endpoint #128 , then:
- merge master in here
- include indexing on bootstrap
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java
Show resolved
Hide resolved
Pfeil
force-pushed
the
add-prefix-harvesting-cli
branch
from
April 12, 2023 07:42
42eb44c
to
db44b04
Compare
Pfeil
force-pushed
the
add-prefix-harvesting-cli
branch
from
April 21, 2023 10:06
2bc2be9
to
aefd643
Compare
|
Caused overwriting them with unknown time stamp.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.