Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actor.py #17

Merged
merged 1 commit into from
Apr 8, 2015
Merged

Conversation

nolyn
Copy link
Contributor

@nolyn nolyn commented Apr 8, 2015

Statment next_uris == uri was not working as intented, causing mopidy to get stuck in endless loop.

Statment  next_uris == uri was not working as intented, causing mopidy to get stuck in endless loop.
@kingosticks
Copy link
Owner

Oh dear, what I had before was total garbage (need tests).

This PR doesn't do quite what I was trying to do. It's supposed to be more of a last ditch attempt which we only do if there are no more uris left to try. We've already tried (and failed) to use uri so if parse_stream_url returns it back to us it's not that interesting unless we've got nothing else to work with.

It's a big hack, the fact that the scan can fail but the uri is playable is the real issue here. But this PR is much better than an infinite loop, so thanks.

kingosticks added a commit that referenced this pull request Apr 8, 2015
Fix infinite loop in translate_uri.
@kingosticks kingosticks merged commit 6c20ee0 into kingosticks:develop Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants