-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steps to use Tempo as tracing storage via Tempo operator #677
Conversation
netlify link for reviewers to look at: https://deploy-preview-677--kiali.netlify.app/docs/configuration/p8s-jaeger-grafana/jaeger/#use-jaeger-frontend-with-grafana-tempo-tracing-backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually ran any of this, but other than the trivial change request, the documentation itself looks good.
provides a native Kubernetes solution to deploy Tempo easily in your system. | ||
|
||
After installing the Tempo Operator in your cluster, you can create a new | ||
Tempo instance with the following CRD: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a CRD (a CustomResourceDefinition).. this is an instance of the tempo CRD - aka a "Custom Resource" or CR:
Tempo instance with the following CRD: | |
Tempo instance with the following CR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops. I typed too fast. Thanks!
Thanks @iblancasa ! Last week we had a user get things working as described here, does that look correct to you, and does the PR cover his configuration? |
I covered here the creation of a Tempo instance using the Kubernetes Operator. That description uses Helm. I think we should cover both. Also the method described in the official Tempo documentation. But as part of different PRs to make it easier to give feedback/review. Sorry anyway for the delay. Lot of stuff in progress. |
Ah, I see, thanks. This looks good to ne but I added @aljesusg as a reviewer. GIven your feedback I added two more subtasks to the Epic kiali/kiali#5850. One for Helm and one for Tempo docs. Will you be able to help with those as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
Yes. I'll try my best :D |
Add a new section to explain how to use Tempo (with the Tempo Operator) as tracing storage.
Later, we can add more sections about how to do the same using Heml or other deployment modes that can be interesting for the users.