Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsers without bigint support in JS: No identifiers allowed directly after numeric literal #66

Closed
andwun opened this issue Sep 8, 2020 · 0 comments · Fixed by #67
Closed

Comments

@andwun
Copy link
Contributor

andwun commented Sep 8, 2020

I wanted to give the dispatch demo at https://dispatch.khlieng.com/ a try.
After the login page I consistently only see a blank screen in Safari on both macOS 10.15 (Safari version Version 13.1.2) and iOS 13.
Some similar issue has been mentioned in issue #8.
The console showed the error message No identifiers allowed directly after numeric literal from some minified JS file.
I was able to track this down to the use of bigints in github.com/sindresorhus/fnv1a v2.0.0+ which don't seem to be supported in Safari 13, yet (see issue #10 at fnv1a for more details).
client/js/utils/color.js:L19 seems to be the only place where the fnv1a hash function is used to implement the colored nicknames feature.
Would it be an option to downgrade fnv1a to 1.2.0 or replace it with another hash function to improve browser compatibility?

khlieng added a commit that referenced this issue Sep 16, 2020
client: Downgraded @sindresorhus/fnv1a to v1.2.0 to fix #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant