Fix keystone build not exiting with versions of NextJS > 13.4.12
#8788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisno2
changed the title
keystone build hanging with latest versions of NextJSkeystone build not exiting with latest versions of NextJS
dcousens
changed the title
keystone build not exiting with latest versions of NextJSkeystone build process not exiting with latest versions of NextJS
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98ccc48:
|
borisno2
force-pushed
the
exit-next-build
branch
from
b7e33ff
to
67dae46
Compare
borisno2
changed the title
keystone build process not exiting with latest versions of NextJSkeystone build not exiting with versions of NextJS > 13.4.12
dcousens
approved these changes
Aug 29, 2023
dcousens
reviewed
Aug 30, 2023
| return build(cwd, defaultFlags(flags, { frozen: false, prisma: true, ui: true })); | ||
| return build(cwd, defaultFlags(flags, { frozen: false, prisma: true, ui: true })).then(() => | ||
| process.exit(0) | ||
| ); |
|
When will be this release? I cannot wait to see my keystone app in production. |
|
Nice work, can't wait for the next release 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a
process.exit(0)after the next build in thekeystone buildcli.Fixes #8760
Fixes #8581
This is required due to the use of the undocumented
next/dist/buildsee - vercel/next.js#54494