Fix access.filter.* passing listKey: undefined
#8122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dcousens
commented
Nov 24, 2022
| session: context.session, | ||
| list: list.listKey, | ||
| context, | ||
| } as any); // TODO: FIXME |
dcousens
commented
Nov 24, 2022
| session: context.session, | ||
| listKey: list.listKey, | ||
| context, | ||
| }); |
There was a problem hiding this comment.
Verbose, but, at least it type checks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d4ea09:
|
dcousens
commented
Nov 24, 2022
flexdinesh
approved these changes
Nov 24, 2022
Merged
dcousens
added a commit
that referenced
this pull request
Nov 25, 2022
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8121 where
access.filter.*operations were being passedlist: list.listKeyinstead oflistKey: list.listKey.The typo fell through our types because we had an
as anywith the type being difficult to resolve.Prior to c740ba6 we had
@ts-ignorefor this check:keystone/packages/core/src/lib/core/access-control.ts
Lines 63 to 67 in 6c60565
And then with #7914 we changed it to
as anyand introduced the regression (as shown in the pull request diff).With this pull request, we resolve the types verbosely. Not ideal, but, it's better than the alternative.