Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relationship fields not using their ui.labelField configuration #8049

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Fix relationship fields not using their ui.labelField configuration #8049

merged 5 commits into from
Nov 7, 2022

Conversation

georgekrax
Copy link
Contributor

Now it should work just fine!

@changeset-bot

This comment was marked as resolved.

Sign in to view
@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 4:51AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit feb038c:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview October 27, 2022 23:08 Inactive
@dcousens dcousens changed the title "ui.labelField" did not work on relationship() Field "ui.labelField" did not work for a relationship() field Oct 28, 2022
@dcousens dcousens changed the title Field "ui.labelField" did not work for a relationship() field Fix relationship fields not using their ui.labelField configuration Oct 28, 2022
@vercel vercel bot temporarily deployed to Preview October 28, 2022 03:05 Inactive
@georgekrax
Copy link
Contributor Author

georgekrax commented Oct 28, 2022 •
edited
Loading

@dcousens It still does not work properly! The value selected in the select component is correct, but when I click the <RelationShipSelect /> the dropdown options still show the wrong labelField

@georgekrax georgekrax mentioned this pull request Oct 28, 2022
Closed
@dcousens dcousens self-assigned this Oct 29, 2022
@vercel vercel bot temporarily deployed to Preview November 3, 2022 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview November 7, 2022 00:24 Inactive
@dcousens dcousens merged commit 5525800 into keystonejs:main Nov 7, 2022
@dcousens
Copy link
Member

dcousens commented Nov 7, 2022

Thanks @georgekrax for finding and reporting this; the help is really appreciated 💛

@keystonejs-release-bot keystonejs-release-bot mentioned this pull request Nov 7, 2022
Merged
@georgekrax
Copy link
Contributor Author

@dcousens Thank you for your kind words. However, the issue is not fully resolved even now. The select relationship list is not updated. Please refer to my previous comments.

@dcousens dcousens mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees

@dcousens dcousens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgekrax @dcousens