Fixes admin meta not using custom controller #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f4ede37:
|
dcousens
changed the title
dcousens
changed the title
emmatown
approved these changes
Oct 26, 2022
Merged
Merged
dcousens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this piece of code suggest that we should be able to override the
controllerhttps://github.com/gautamsi/keystone/blob/e08b866f57ba85e18a3cfd131a6bf945e700e11a/packages/core/src/admin-ui/utils/useAdminMeta.tsx#L100
but this specific line does not make is of overridden
controllerhttps://github.com/gautamsi/keystone/blob/e08b866f57ba85e18a3cfd131a6bf945e700e11a/packages/core/src/admin-ui/utils/useAdminMeta.tsx#L114