No automatic many-prefixing when isSingleton is set #7995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
force-pushed
the
no-many-prefix
branch
from
996ad15
to
25227c6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
force-pushed
the
no-many-prefix
branch
from
25227c6
to
eeb2a2d
Compare
emmatown
approved these changes
Oct 12, 2022
Comment on lines
+286
to
+288
| seoConfigurations { | ||
| title | ||
| description |
There was a problem hiding this comment.
Not a blocking thing but showing the many query feels unnecessary. It's not like you would actually want to use it. A note like "hey, the many things still exist for reasons" would certainly be helpful but actually showing it feels like we're saying that there's a reason people would want it when there isn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't intuitive, and we have a robust solution for resolving ambiguities already:
graphql.pluralRelated