Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing fields inside of a conditional field in a component block creating a broken structure #7922

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Sep 13, 2022

This pull request fixes a broken code path for conditional component-blocks when the fields are missing from the database value.

This previously resulted in invalid data structures within the document editor.

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 5:41AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

🦋 Changeset detected

Latest commit: 302b846

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-6/fields-document Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmatown emmatown marked this pull request as ready for review September 13, 2022 04:50
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 302b846:

Sandbox Source
@keystone-6/sandbox Configuration

@emmatown emmatown requested a review from a team September 13, 2022 04:50
@vercel vercel bot temporarily deployed to Preview September 13, 2022 04:53 Inactive
@vercel vercel bot temporarily deployed to Preview September 13, 2022 05:41 Inactive
@emmatown emmatown merged commit 72b7f3a into main Sep 13, 2022
@emmatown emmatown deleted the fix-missing-fields-in-a-conditional-field branch September 13, 2022 07:30
dcousens pushed a commit that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants