Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom field example smoke test #7818

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix custom field example smoke test #7818

merged 1 commit into from
Aug 22, 2022

Conversation

emmatown
Copy link
Member

No description provided.

@emmatown emmatown requested a review from a team August 22, 2022 01:26
@vercel
Copy link

vercel bot commented Aug 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 1:31AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

⚠️ No Changeset found

Latest commit: eea3ab9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emmatown emmatown enabled auto-merge (squash) August 22, 2022 01:27
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eea3ab9:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview August 22, 2022 01:31 Inactive
flexdinesh
flexdinesh approved these changes Aug 22, 2022
View reviewed changes
tests/examples-smoke-tests/custom-field.test.ts
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("Authors")')]);
await page.waitForSelector('a:has-text("Create Author")');
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("Posts")')]);
await page.waitForSelector('a:has-text("Create Post")');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did the tests pass all this time? 🤔

@emmatown emmatown merged commit ca45fca into main Aug 22, 2022
@emmatown emmatown deleted the fix-custom-field-example-smoke-test branch August 22, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexdinesh flexdinesh flexdinesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmatown @flexdinesh