Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use flag to more conservatively version peerdeps #7770

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

Noviny
Copy link
Contributor

@Noviny Noviny commented Aug 4, 2022

Currently, whenever @keystone/core publishes a new feature, this results in a major release of packages that rely on it as a peerDependency (such as @keystone-6/auth).

There are sound versioning reasons to do this, but with the style of monorepo keystone is, and the way keystone is maintained means that this is hurting consumers while providing us with coverage from a small error class.

The new plan is to not aggressively bump packages that have a peer dependency, and instead to, when new versions of them are published, ensure that they are using the latest version of core at that time.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

⚠️ No Changeset found

Latest commit: ca4a531

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 3:35AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca4a531:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens enabled auto-merge (squash) August 10, 2022 06:19
@dcousens dcousens merged commit 7a431a9 into main Aug 10, 2022
@dcousens dcousens deleted the version-peerdeps-less-often branch August 10, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants