Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for configuring additional properties to be printed in the prisma schema datasource #7747

Merged
merged 6 commits into from
Aug 12, 2022

Conversation

willemmulder
Copy link

This allows us for example to define referentialIntegrity = "prisma" which is required for databases like PlanetScale

…the prisma schema datasource. This allows us for example to define `referentialIntegrity = "prisma"` which is required for databases like PlanetScale.
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022

🦋 Changeset detected

Latest commit: adab227

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@keystone-6/core Minor
@keystone-6/auth Major
@keystone-6/cloudinary Major
@keystone-6/fields-document Major
@keystone-6/session-store-redis Major
@keystone-6/example-auth Patch
@keystone-6/examples-app-basic Patch
@keystone-6/example-with-custom-session-validation Patch
@keystone-6/example-ecommerce Patch
@keystone-6/example-graphql-api-endpoint Patch
@keystone-6/example-roles Patch
@keystone-6/example-testing Patch
@keystone-6/example-with-auth Patch
@keystone-6/sandbox Patch
@keystone-6/website Patch
@keystone-6/example-document-field Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 10:17PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 29, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit adab227:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview July 29, 2022 13:40 Inactive
@willemmulder
Copy link
Author

willemmulder commented Aug 4, 2022

Is this linting error something I can fix? I don't see any specific error, and also on my local machine I get a generic "error Command failed with exit code 1"...

@borisno2
Copy link
Member

borisno2 commented Aug 9, 2022

Is this linting error something I can fix? I don't see any specific error, and also on my local machine I get a generic "error Command failed with exit code 1"...

Hi @willemmulder... Thanks for the PR!! Running yarn lint on your local machine will show you the files that need fixing, and running yarn format will format those files for you.

Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 9, 2022 09:38 Inactive
@vercel vercel bot temporarily deployed to Preview August 10, 2022 05:57 Inactive
@willemmulder
Copy link
Author

Is this linting error something I can fix? I don't see any specific error, and also on my local machine I get a generic "error Command failed with exit code 1"...

Hi @willemmulder... Thanks for the PR!! Running yarn lint on your local machine will show you the files that need fixing, and running yarn format will format those files for you.

Thanks! The yarn lint command does not provide any useful error message on my PC (still the "error Command failed with exit code 1") but yarn format does the trick! :-)

@vercel vercel bot temporarily deployed to Preview August 10, 2022 22:17 Inactive
@dcousens
Copy link
Member

@willemmulder that shouldn't happen next time

@willemmulder
Copy link
Author

willemmulder commented Aug 11, 2022

@willemmulder that shouldn't happen next time

Ah nice. Thanks for the update!

@willemmulder
Copy link
Author

willemmulder commented Aug 12, 2022

@dcousens Just to be sure: the linting is fixed.

This is another check that fails. But I think running these checks again would solve the issue, because it is a connection timeout error. Thanks :-)

@dcousens
Copy link
Member

Thanks @willemmulder! 💙

@dcousens dcousens merged commit e322ce1 into keystonejs:main Aug 12, 2022
@willemmulder
Copy link
Author

Thanks for merging! I'll be trying out PlanetScale first thing once the new release is out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants