Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .keystone/types to .keystone and add graphql export to .keystone #7733

Closed
wants to merge 7 commits into from

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Jul 21, 2022

This adds a graphql export to .keystone (renamed from .keystone/types because with the graphql export, it is no longer just types) that is the same as the graphql export from @keystone-6/core but uses the specific generated context type for the project. This is important for #7575 since not using the specific context will be more painful but it also generally improves the experience of using graphql-ts for schema extensions and virtual fields.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

🦋 Changeset detected

Latest commit: 112a8f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@keystone-6/core Minor
@keystone-6/auth Major
@keystone-6/cloudinary Major
@keystone-6/fields-document Major
@keystone-6/session-store-redis Major
@keystone-6/example-auth Patch
@keystone-6/examples-app-basic Patch
@keystone-6/example-with-custom-session-validation Patch
@keystone-6/example-ecommerce Patch
@keystone-6/example-graphql-api-endpoint Patch
@keystone-6/example-roles Patch
@keystone-6/example-testing Patch
@keystone-6/example-with-auth Patch
@keystone-6/sandbox Patch
@keystone-6/website Patch
@keystone-6/example-document-field Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 2:23AM (UTC)

@vercel vercel bot temporarily deployed to Preview July 21, 2022 06:43 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 112a8f8:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview July 25, 2022 01:28 Inactive
@vercel vercel bot temporarily deployed to Preview July 25, 2022 03:18 Inactive
@emmatown emmatown changed the title Add graphql export to .keystone/types Rename .keystone/types to .keystone and add graphql export to .keystone Jul 25, 2022
@emmatown emmatown marked this pull request as ready for review July 25, 2022 03:33
@emmatown emmatown requested a review from a team July 25, 2022 03:33
@emmatown emmatown force-pushed the graphql-ts-api-for-specific-context branch from 16a9f42 to 514e7bd Compare July 25, 2022 03:42
@vercel vercel bot temporarily deployed to Preview July 25, 2022 03:51 Inactive
@dcousens dcousens force-pushed the graphql-ts-api-for-specific-context branch from 011f3d7 to 3236e70 Compare August 9, 2022 02:58
@vercel vercel bot temporarily deployed to Preview August 9, 2022 03:00 Inactive
@dcousens dcousens force-pushed the graphql-ts-api-for-specific-context branch from 3236e70 to 5370579 Compare August 9, 2022 03:01
@vercel vercel bot temporarily deployed to Preview August 9, 2022 03:05 Inactive
@vercel vercel bot temporarily deployed to Preview August 9, 2022 03:15 Inactive
@vercel vercel bot temporarily deployed to Preview August 10, 2022 02:23 Inactive
@dcousens dcousens modified the milestone: M5: Later Oct 3, 2022
@dcousens
Copy link
Member

I don't think we want to do this at this time.

That may change in the future, but for now I will close this pull request.

@dcousens dcousens closed this Oct 25, 2022
@dcousens dcousens deleted the graphql-ts-api-for-specific-context branch March 20, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants