Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null to return type of findOne #7731

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Add null to return type of findOne #7731

merged 3 commits into from
Jul 21, 2022

Conversation

nderkim
Copy link
Contributor

@nderkim nderkim commented Jul 20, 2022

Fix return type of findOne to include null, which is returned if no item is found

@changeset-bot

This comment was marked as resolved.

@vercel
Copy link

vercel bot commented Jul 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 7:40AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64427a8:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview July 20, 2022 07:49 Inactive
@vercel vercel bot temporarily deployed to Preview July 20, 2022 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview July 20, 2022 12:36 Inactive
@dcousens dcousens changed the title Fix return type of findOne Add null to return type of findOne Jul 21, 2022
@vercel vercel bot temporarily deployed to Preview July 21, 2022 07:06 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2022 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2022 07:40 Inactive
Copy link
Member

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nderkim!
I have added a test and changed the copy on the changeset to get this merged 👍

@dcousens dcousens merged commit bf70aa6 into keystonejs:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants