Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiselect field #7683

Merged
merged 6 commits into from
Aug 10, 2022
Merged

Add multiselect field #7683

merged 6 commits into from
Aug 10, 2022

Conversation

Achisingh
Copy link
Contributor

This adds a multiselect field that mirrors the select field options.

  • It is always non-nullable
  • It is stored as a json array in databases

In this PR it does not have any filters and it is not orderable. It may change in the future PRs.

@changeset-bot

This comment was marked as resolved.

Sign in to view
@vercel
Copy link

vercel bot commented Jul 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 6:16AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 90b98f6:

Sandbox Source
@keystone-6/sandbox Configuration

@emmatown emmatown marked this pull request as ready for review July 1, 2022 00:50
@emmatown emmatown requested a review from a team July 1, 2022 00:50
@vercel vercel bot temporarily deployed to Preview July 1, 2022 00:53 Inactive
@gautamsi
Copy link
Member

gautamsi commented Jul 2, 2022

what about adding this as , separated string in database? this , should be configurable delimiter

caveat is that search for new will also fetch news but that can have workaround

@emmatown
Copy link
Member

emmatown commented Jul 3, 2022

what about adding this as , separated string in database? this , should be configurable delimiter

What would be the advantage of doing that?

@vercel vercel bot temporarily deployed to Preview July 3, 2022 23:34 Inactive
@gautamsi
Copy link
Member

gautamsi commented Jul 4, 2022

What would be the advantage of doing that?

  • this avoids json fields and you can add Filters in this.

If there are filters (maybe I missed) for multiselect value combinations I am good with this.

@vercel vercel bot temporarily deployed to Preview August 4, 2022 01:52 Inactive
@dcousens dcousens enabled auto-merge (squash) August 4, 2022 05:12
@vercel vercel bot temporarily deployed to Preview August 4, 2022 05:18 Inactive
@vercel vercel bot temporarily deployed to Preview August 4, 2022 06:16 Inactive
@dcousens dcousens merged commit 9d3e406 into main Aug 10, 2022
@dcousens dcousens deleted the add-multiselect-field branch August 10, 2022 05:10
@keystonejs-release-bot keystonejs-release-bot mentioned this pull request Aug 10, 2022
Merged
@rafenden
Copy link

rafenden commented Sep 3, 2023

Any updates on the filters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisno2 borisno2 borisno2 left review comments

@emmatown emmatown emmatown left review comments

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Achisingh @gautamsi @emmatown @rafenden @dcousens @borisno2