Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-day-picker to v8 #7497

Merged
merged 5 commits into from
May 3, 2022
Merged

Update react-day-picker to v8 #7497

merged 5 commits into from
May 3, 2022

Conversation

borisno2
Copy link
Member

React-day-picker upgrade to v8

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2022

🦋 Changeset detected

Latest commit: b7ca2f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-ui/fields Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 3:16AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 28, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview April 28, 2022 08:53 Inactive
@emmatown
Copy link
Member

This looks pretty close, looks like there's some slight spacing changes and the date & year should be center aligned?

This PR:
screenshot of Keystone's date picker on this PR with extra spacing that looks strange and unaligned text

Before this PR:
screenshot of Keystone's date picker before this PR with spacing that looks correct and aligned text

Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
@vercel vercel bot temporarily deployed to Preview April 29, 2022 02:25 Inactive
@vercel vercel bot temporarily deployed to Preview April 29, 2022 03:16 Inactive
@borisno2 borisno2 marked this pull request as ready for review April 29, 2022 03:18
@borisno2
Copy link
Member Author

borisno2 commented May 3, 2022

Screen shot of date picker after the latest changes
Screen Shot 2022-04-29 at 1 05 07 pm

See @mitchellhamilton comment for Before

@borisno2 borisno2 merged commit 73f4d56 into main May 3, 2022
@borisno2 borisno2 deleted the update-react-day-picker branch May 3, 2022 02:33
dcousens pushed a commit that referenced this pull request May 11, 2022
dcousens pushed a commit that referenced this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants