Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assorted filter pill fixes #5987

Merged
merged 19 commits into from
Jun 28, 2021
Merged

assorted filter pill fixes #5987

merged 19 commits into from
Jun 28, 2021

Conversation

gwyneplaine
Copy link
Contributor

@gwyneplaine gwyneplaine commented Jun 25, 2021

  • resolves Filter items are not very SR friendly #5939 by adding aria-label and aria-description to pill
  • fixes autoFocus always being on in text field Filter component
  • revert redundant status="role" on editDialog
  • Added containerProps prop to Pill component in design-system that are spread onto the container element, props are now spread onto the PillButton element by default.
  • Ensured trigger.ref is applied to PillButton ref and not the pill container ref (which previously broke focus)
  • Fixed issue with filters not always being removable (due to undocumented breaking change with Next)

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2021

🦋 Changeset detected

Latest commit: 06429d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@keystone-next/keystone Patch
@keystone-ui/popover Patch
@keystone-ui/pill Major
@keystone-next/fields Patch
@keystone-next/cloudinary Patch
@keystone-ui/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/6MvLPq2etqofSohRa9UN2X3q1UCe
✅ Preview: https://keystone-next-docs-git-5939-filter-pills-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview June 25, 2021 06:28 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 25, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview June 25, 2021 07:13 Inactive
@vercel vercel bot temporarily deployed to Preview June 25, 2021 07:27 Inactive
@vercel vercel bot temporarily deployed to Preview June 25, 2021 07:59 Inactive
Copy link
Member

@JedWatson JedWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice fixes

Copy link
Member

@JedWatson JedWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised, this needs a changeset!

@vercel vercel bot temporarily deployed to Preview June 27, 2021 23:45 Inactive
@gwyneplaine gwyneplaine requested review from JedWatson and a team June 27, 2021 23:46
@vercel vercel bot temporarily deployed to Preview June 28, 2021 00:02 Inactive
@vercel vercel bot temporarily deployed to Preview June 28, 2021 00:08 Inactive
@gwyneplaine gwyneplaine enabled auto-merge (squash) June 28, 2021 00:10
@timleslie timleslie disabled auto-merge June 28, 2021 00:27
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timleslie timleslie dismissed JedWatson’s stale review June 28, 2021 00:28

Changsets added as requested.

@gwyneplaine gwyneplaine removed the request for review from JedWatson June 28, 2021 00:29
@vercel vercel bot temporarily deployed to Preview June 28, 2021 01:07 Inactive
@timleslie timleslie enabled auto-merge (squash) June 28, 2021 01:07
@timleslie timleslie merged commit 972e045 into master Jun 28, 2021
@timleslie timleslie deleted the 5939/filter-pills branch June 28, 2021 01:14
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 13, 2021
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter items are not very SR friendly
3 participants