New id fields #5947

emmatown · 2021-06-22T00:41:43Z

This replaces the idField option accepting regular field types to an object that can specify cuids, uuids or autoincrements. The default is now cuid instead of autoincrement

changeset-bot · 2021-06-22T00:41:45Z

🦋 Changeset detected

Latest commit: 61fa311

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@keystone-next/keystone	Major
@keystone-next/types	Major
@keystone-next/benchmarks-legacy	Patch
@keystone-next/example-blog	Patch
@keystone-next/example-default-values	Patch
@keystone-next/example-document-field	Patch
@keystone-next/example-extend-graphql-schema	Patch
@keystone-next/example-json-field	Patch
@keystone-next/example-task-manager	Patch
@keystone-next/example-testing	Patch
@keystone-next/example-virtual-field	Patch
@keystone-next/example-with-auth	Patch
@keystone-next/example-assets-cloud	Patch
@keystone-next/example-assets-local	Patch
@keystone-next/example-auth	Patch
@keystone-next/examples-app-basic	Patch
@keystone-next/example-ecommerce	Patch
@keystone-next/example-embedded-nextjs	Patch
keystone-next-app	Patch
@keystone-next/example-playground	Patch
@keystone-next/example-roles	Patch
@keystone-next/example-sandbox	Patch
@keystone-next/auth	Major
@keystone-next/fields-document	Patch
@keystone-next/fields	Patch
@keystone-next/testing	Patch
@keystone-next/api-tests-legacy	Patch
@keystone-next/admin-ui-utils	Patch
@keystone-next/cloudinary	Patch
@keystone-next/utils	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2021-06-22T00:43:25Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/9gLvjGKny4Gkg3Z1A9TeRYnanpwb
✅ Preview: https://keystone-next-docs-git-id-field-experimenting-keystonejs.vercel.app

codesandbox-ci · 2021-06-22T03:30:06Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

gautamsi · 2021-06-22T10:34:30Z

Can we have id field config globally in keystone config?

I am thinking we would also want to map it for provider, once mongodb is there we can have mongoid or dbgenerated option.

packages-next/keystone/src/lib/id-field.ts

emmatown · 2021-06-28T01:37:35Z

packages-next/keystone/src/lib/id-field.ts

+    // isCuid is just "it's a string and it starts with c"
+    // https://github.com/ericelliott/cuid/blob/215b27bdb78d3400d4225a4eeecb3b71891a5f6f/index.js#L69-L73
+    if (typeof val === 'string' && isCuid(val)) {
+      return val;


Note not lower-casing here is a difference from what we discussed. My thinking is that isCuid only accepts strings that with c(as in only lower-case c) so treating it as case insensitive seems strange.

docs/pages/docs/apis/config.mdx

Co-authored-by: Tim Leslie <timl@thinkmill.com.au>

.changeset/eight-lions-stare.md

timleslie

👍 pending changeset update.

Co-authored-by: Tim Leslie <timl@thinkmill.com.au>

* Id field experimenting * word * Try a different default to see what our tests do * Update things * snapshots * Update things * Remove a thing * field view * Fix ts errors * WIP * Fix a thing * Fix more tests * Fix things * Fix more things * More fixes * Reorder a thing so the failing output is easy to debug * Try a thing * Update schemas * Tests * Update docs * Add uuid dep * Changeset * Words * Add another changeset * Some more tests and cuid change * Update docs/pages/docs/apis/config.mdx Co-authored-by: Tim Leslie <timl@thinkmill.com.au> * Update docs/pages/docs/apis/config.mdx Co-authored-by: Tim Leslie <timl@thinkmill.com.au> * Update .changeset/eight-lions-stare.md Co-authored-by: Tim Leslie <timl@thinkmill.com.au> Co-authored-by: Tim Leslie <timl@thinkmill.com.au>

emmatown added 2 commits June 22, 2021 10:39

Id field experimenting

c1f1905

word

09ff5b2

vercel bot temporarily deployed to Preview June 22, 2021 00:43 Inactive

Try a different default to see what our tests do

c317d4a

vercel bot temporarily deployed to Preview June 22, 2021 00:48 Inactive

Update things

0bd9cc5

vercel bot temporarily deployed to Preview June 22, 2021 03:26 Inactive

snapshots

0c2193a

vercel bot temporarily deployed to Preview June 22, 2021 03:41 Inactive

timleslie reviewed Jun 23, 2021

View reviewed changes

packages-next/keystone/src/lib/id-field.ts Outdated Show resolved Hide resolved

Update things

a466173

vercel bot temporarily deployed to Preview June 24, 2021 02:12 Inactive

Remove a thing

3a7cbb5

vercel bot temporarily deployed to Preview June 24, 2021 02:16 Inactive

field view

a1dd2dc

vercel bot temporarily deployed to Preview June 25, 2021 01:23 Inactive

Fix ts errors

7868747

vercel bot temporarily deployed to Preview June 25, 2021 02:21 Inactive

WIP

5d1768a

vercel bot temporarily deployed to Preview June 25, 2021 03:42 Inactive

Merge branch 'master' into id-field-experimenting

4c03162

vercel bot temporarily deployed to Preview June 25, 2021 03:44 Inactive

Merge branch 'master' into id-field-experimenting

ca6763b

vercel bot temporarily deployed to Preview June 25, 2021 03:58 Inactive

Fix a thing

efd8bc3

vercel bot temporarily deployed to Preview – keystone-next-docs June 25, 2021 04:45 Inactive

emmatown marked this pull request as draft June 28, 2021 01:26

Merge branch 'master' into id-field-experimenting

42f449a

vercel bot temporarily deployed to Preview June 28, 2021 01:29 Inactive

Some more tests and cuid change

347ee28

emmatown commented Jun 28, 2021

View reviewed changes

emmatown marked this pull request as ready for review June 28, 2021 01:38

emmatown requested a review from timleslie June 28, 2021 01:38

vercel bot temporarily deployed to Preview June 28, 2021 01:39 Inactive

timleslie reviewed Jun 28, 2021

View reviewed changes

docs/pages/docs/apis/config.mdx Outdated Show resolved Hide resolved

timleslie reviewed Jun 28, 2021

View reviewed changes

docs/pages/docs/apis/config.mdx Outdated Show resolved Hide resolved

Update docs/pages/docs/apis/config.mdx

bc947f5

Co-authored-by: Tim Leslie <timl@thinkmill.com.au>

vercel bot temporarily deployed to Preview June 28, 2021 02:31 Inactive

Update docs/pages/docs/apis/config.mdx

8cbacc4

Co-authored-by: Tim Leslie <timl@thinkmill.com.au>

vercel bot temporarily deployed to Preview June 28, 2021 02:35 Inactive

Merge branch 'master' into id-field-experimenting

970d2e5

vercel bot temporarily deployed to Preview June 28, 2021 02:45 Inactive

timleslie reviewed Jun 29, 2021

View reviewed changes

.changeset/eight-lions-stare.md Outdated Show resolved Hide resolved

timleslie approved these changes Jun 29, 2021

View reviewed changes

Update .changeset/eight-lions-stare.md

14479ee

Co-authored-by: Tim Leslie <timl@thinkmill.com.au>

vercel bot temporarily deployed to Preview June 29, 2021 03:16 Inactive

Merge branch 'master' into id-field-experimenting

61fa311

emmatown enabled auto-merge (squash) June 29, 2021 03:16

vercel bot temporarily deployed to Preview June 29, 2021 03:19 Inactive

emmatown merged commit 03f535b into master Jun 29, 2021

emmatown deleted the id-field-experimenting branch June 29, 2021 03:24

keystonejs-release-bot mentioned this pull request Jun 29, 2021

Version Packages #6021

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New id fields #5947

New id fields #5947

emmatown commented Jun 22, 2021 •

edited

Loading

changeset-bot bot commented Jun 22, 2021 •

edited

Loading

vercel bot commented Jun 22, 2021 •

edited

Loading

codesandbox-ci bot commented Jun 22, 2021 •

edited

Loading

gautamsi commented Jun 22, 2021

emmatown Jun 28, 2021

timleslie left a comment

New id fields #5947

New id fields #5947

Conversation

emmatown commented Jun 22, 2021 • edited Loading

changeset-bot bot commented Jun 22, 2021 • edited Loading

🦋 Changeset detected

vercel bot commented Jun 22, 2021 • edited Loading

codesandbox-ci bot commented Jun 22, 2021 • edited Loading

gautamsi commented Jun 22, 2021

emmatown Jun 28, 2021

Choose a reason for hiding this comment

timleslie left a comment

Choose a reason for hiding this comment

emmatown commented Jun 22, 2021 •

edited

Loading

changeset-bot bot commented Jun 22, 2021 •

edited

Loading

vercel bot commented Jun 22, 2021 •

edited

Loading

codesandbox-ci bot commented Jun 22, 2021 •

edited

Loading