Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Remove the utils-legacy package #5927

Closed
wants to merge 3 commits into from
Closed

Conversation

timleslie
Copy link
Contributor

At this point this package only contains a couple of helpers for images and files. I don't think that justifies an entire package. I've moved the code into places that make the most sense to me as a POC. @mitchellhamilton perhaps you have some thoughts on how we should be sharing code across the keystone and fields packages?

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2021

⚠️ No Changeset found

Latest commit: 2a7b456

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/3pQCHVR3mw2HcHtttMskQ4xGoeGw
✅ Preview: https://keystone-next-docs-git-remove-utils-package-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview June 17, 2021 23:08 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 17, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview June 17, 2021 23:13 Inactive
@vercel vercel bot temporarily deployed to Preview June 17, 2021 23:16 Inactive
@emmatown
Copy link
Member

imo leaving this package as it is is better than exporting some of these things from the keystone package since then breaking changes to these mean a major for the keystone package. the "share code but the sharing is just implementation details which aren't part of our public API of our main things" use case here is actually fine imo and this separate package isn't harming anything

@timleslie
Copy link
Contributor Author

Yep, that's fair. I think it also serves well as a holding place for other code that needs to be shared across packages in the future. In that case I think we should promote this package from @keystone-next/utils-legacy to @keystone-next/utils and move it into the packages-next directory.

@emmatown
Copy link
Member

Yeah, sgtm

@timleslie timleslie closed this Jun 21, 2021
@timleslie timleslie deleted the remove-utils-package branch June 21, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants