-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Remove the utils-legacy package #5927
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/3pQCHVR3mw2HcHtttMskQ4xGoeGw |
f99d5a8
to
b586589
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
imo leaving this package as it is is better than exporting some of these things from the |
Yep, that's fair. I think it also serves well as a holding place for other code that needs to be shared across packages in the future. In that case I think we should promote this package from |
Yeah, sgtm |
At this point this package only contains a couple of helpers for images and files. I don't think that justifies an entire package. I've moved the code into places that make the most sense to me as a POC. @mitchellhamilton perhaps you have some thoughts on how we should be sharing code across the
keystone
andfields
packages?