Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Admin UI generation to allow files returned from getAdditionalFiles to overwrite the files generated by Keystone #5920

Conversation

emmatown
Copy link
Member

The original intent of this was to allow overwriting the files that Keystone generates but the comparison was broken because it was comparing unresolved paths with resolved ones.

@emmatown emmatown requested a review from a team June 17, 2021 03:50
@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2021

🦋 Changeset detected

Latest commit: 37c3a64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystone-next/keystone Patch
@keystone-next/test-utils-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/GsJzZotfz6AtHDrtx7Xd19b4EKr3
✅ Preview: https://keystone-next-docs-git-fix-get-additional-fil-25db7d-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview June 17, 2021 03:51 Inactive
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmatown emmatown merged commit 123042b into master Jun 17, 2021
@emmatown emmatown deleted the fix-get-additional-files-to-allow-overwriting-default-generated-files branch June 17, 2021 03:58
@gautamsi
Copy link
Member

@mitchellhamilton does this also overwrite the file with typescript? I have noticed that f you have same file name created as custom pages in typescript, it does copy and use Typescript file but the js file from template is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants