Cleanup the test-utils package code #5883
Conversation
🦋 Changeset detectedLatest commit: 5c9634b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/2xiBwZsq2XSYcLmprBsppnJpTRYU |
timleslie
force-pushed
the
update-test-utils
branch
from
96dd5c5
to
7560be3
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
packages/test-utils/src/index.ts
Outdated
| import memoizeOne from 'memoize-one'; | ||
|
|
||
| export type ProviderName = 'postgresql' | 'sqlite'; | ||
| export type ProviderName = NonNullable<DatabaseConfig['provider']>; |
There was a problem hiding this comment.
Can you use the DatabaseProvider type from the types package? (as in don't export this)
There was a problem hiding this comment.
Ah, yes, that's exactly what I wanted! I somehow managed to go looking for it in the once place it's not explicitly used 🤦
Mostly cosmetic changes inside the
test-utilspackage. I'd like to get this ready to have a bit of a face-lift and for us to give a bit of consideration to the desired API here so that we can promote it from alegacypackage to a fully documented feature that people can use to test their own keystone systems.