Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sameSite option to sessions #5774

Merged
merged 4 commits into from
May 23, 2021

Conversation

jonowu
Copy link
Contributor

@jonowu jonowu commented May 22, 2021

Adds a sameSite option to the session options for cookies. Can be one of true, false, 'strict', 'lax' or 'none' as per Mozilla docs. The option defaults to 'lax' which is in line with existing behaviour.

This option will be useful for users who have deployed their keystone instance to a different site from their frontend, e.g. hosting keystone on example.herokuapp.com with the frontend on example.vercel.app.

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2021

🦋 Changeset detected

Latest commit: 7611881

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@keystone-next/website Minor
@keystone-next/keystone Minor
@keystone-next/test-utils-legacy Patch
@keystone-next/auth Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-with-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/n7oEeBphfkrNLyFYGzTGXNWE59qB
✅ Preview: https://keystone-next-git-fork-jonowu-add-same-site-option-to-s-19bbb7.vercel.app

@vercel vercel bot temporarily deployed to Preview May 22, 2021 11:27 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7611881:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview May 22, 2021 11:38 Inactive
Copy link
Member

@JedWatson JedWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @jonowu!

@JedWatson JedWatson enabled auto-merge (squash) May 23, 2021 14:13
@vercel vercel bot temporarily deployed to Preview May 23, 2021 14:13 Inactive
@JedWatson JedWatson merged commit 107eeb0 into keystonejs:master May 23, 2021
@kilinkis
Copy link

thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants